Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Bug Causing Internal Errors with New Data Format (AYGU-1_MeltR) #183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adhampton110
Copy link
Collaborator

@adhampton110 adhampton110 commented May 31, 2024

Fixes 181

What was changed?

I revised the parsing logic in server.r to comply with MeltR's expected dataset format for files that have the same structure as AYGU-1_MeltR.

Why was it changed?

As stated in the user story, going forward, user input data will be structured like AYGU-1MeltR.csv. The current code strictly supports input files structured like test.csv. My code now supports input files structured like AYGU-1_MeltR.csv, instead of input file structured like test.csv.

How was it changed?

The new input file standard, AYGU-1MeltR.csv, already complies with MeltR, almost. I have added one line that manipulates the data before it interacts with MeltR: data <- raw_data %>% arrange(Sample). This line sorts the input data by the Sample column from lowest to highest (1,2,3,4,...).

Additionally the assignment of numSamples has been changed from NULL to 0. This was done because the following would occur:

9 + NULL = numeric(0). 
# problematic because we are unable to use the varaible later on to iterate during the creation of samples. 

Screenshots that show the changes (if applicable):

Each of the following cases were testing with the following configuration:

  • AYGU-1MeltR.csv input file
  • No Blank
  • 260 Wavelength
  • 90 Temp
  • RNA NucAcid
  • CGAAAGGU,ACCUUUCG Sequence
  • Nucleic Acid Sequence Molar Extinction Coeff.
  • Methods 2 & 3 Enabled
  • nls Tm method
  • Heteroduplex molecular state

Case 1: Windows Machine Running the Application on a Linux Container with R 4.4.0 Installed

Showcase of AYGU-1_MeltR.csv Uploaded

image

Showcase of Best Fit & Derivative Plots for Sample 3

image

Showcase of Vant Hoff

image

Showcase of Table

image

Case 2: Mac Machine Running the Application Locally Using MeltShiny.command with R 4.3.1 Installed

Showcase of AYGU-1_MeltR.csv Uploaded

Screenshot 2024-05-31 at 1 54 12 AM

Showcase of Best Fit & Derivative Plots for Sample 3

Screenshot 2024-05-31 at 1 54 32 AM

Showcase of Vant Hoff

Screenshot 2024-05-31 at 1 54 53 AM

Showcase of Table

Screenshot 2024-05-31 at 1 55 12 AM

@adhampton110 adhampton110 self-assigned this May 31, 2024
@adhampton110 adhampton110 marked this pull request as ready for review May 31, 2024 07:01
@Massi-Papi
Copy link
Collaborator

Wow!! Great work!! @adhampton110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated Data Formatting
2 participants