Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare command #7104

Merged
merged 5 commits into from
Jun 8, 2023
Merged

Compare command #7104

merged 5 commits into from
Jun 8, 2023

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

Align with all other similar code.

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth requested a review from a team as a code owner June 7, 2023 20:51
@sschuberth sschuberth enabled auto-merge (rebase) June 7, 2023 20:51
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.23 ⚠️

Comparison is base (4d656c0) 64.27% compared to head (1eebd08) 64.05%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7104      +/-   ##
============================================
- Coverage     64.27%   64.05%   -0.23%     
  Complexity     1969     1969              
============================================
  Files           333      334       +1     
  Lines         16745    16744       -1     
  Branches       2390     2390              
============================================
- Hits          10763    10725      -38     
- Misses         4942     4982      +40     
+ Partials       1040     1037       -3     
Flag Coverage Δ
funTest-non-docker 28.55% <0.00%> (-0.80%) ⬇️
test 39.83% <0.00%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lin/commands/SetDependencyRepresentationCommand.kt 0.00% <0.00%> (ø)
model/src/main/kotlin/utils/ScanResultUtils.kt 0.00% <0.00%> (ø)
...in/kotlin/provenance/NestedProvenanceScanResult.kt 76.78% <ø> (-5.87%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sschuberth
Copy link
Member Author

FYI @pepper-jk.

@sschuberth sschuberth merged commit 4e3289e into main Jun 8, 2023
17 of 19 checks passed
@sschuberth sschuberth deleted the compare-command branch June 8, 2023 08:36
@sschuberth sschuberth added the release notes Changes that should be mentioned in release notes label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes Changes that should be mentioned in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants