Unusual Layer Tag Bug Fix & Enhancement #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiqingj
approved these changes
Oct 23, 2018
seancoulter
pushed a commit
to seancoulter/atlas-checks
that referenced
this pull request
Dec 12, 2019
* Refactored IntersectingBuildingsCheck to use findIntersectionPercentage() (osmlab#71) * Flag File Diff Commands (osmlab#72) * add AtlasChecksCommand and AtlasChecksGeoJSONDiffSubCommand * multi file supprt; file output; linter cleanup * docs and comments * geo diff unit test * add log diff command * refactored to use abstract class * unit test files * refactor getMissingAndChanged * change AbstractJsonFlagDiffCommand name * refactor to use new abstract class name * refactor json strings * use dir instead of csv's * update test resources * update argument descriptions * remove old resources * this; abstract; docs * more temp dirs * rename command param * handle location props * Invalid Mini Roundabout Check (osmlab#69) * First draft of InvalidMiniRoundaboutCheck * Unit tests written. * Added check to configuration.json and fixed a bug. * Fixed a spacing issue in the output. * quick fix for configuration. * Better fix for the configuration issue. * Updated tests to reflect new flagging scheme. * New tagging scheme and clean up formatting. * Cleaned up instruction output. * Updated tests for car-navigability fix. * Implemented car-navigable fix. * No longer flag 0-edge nodes. Only tag connected car-navigable edges. * Updated check to match new spec RE: direction tags. * Fixed counterclockwise->anticlockwise direction value. * add .md file for invalidMiniRoundaboutCheck * Add challenge description to config. * Fix formatting things. * refactored to remove duplicate code * Clarified wording of .md file. * Refactored to use DirectionTag class, which was just added to Atlas. * Changed a private helper signature and added comments for helper functions. * Removed unnecessary code review from markdown file. * Code cleaning. * Rename minimumValence -> valenceMinimum * Update atlas version. * Code cleaning & clarifying. * Reword instructions, clean up code. * Update instructions. * PR template (osmlab#75) * Use trusty and sudo false for Travis (osmlab#78) * Floating Edge Check Enhancement (osmlab#73) * Add minimum highway type * Refactor variable names * Change minimum highway to Service * Update java doc * Update Sonar badge (osmlab#79) * SinkIsland Enhancements (osmlab#76) * Implemented enhancement and tests. * Make minimum highway importance configurable. * Fix typo * Another typo fix. * Address some easy fixes * fix function name. * Config nit. * Fix function name. * spotlessApply * unregister at complete (osmlab#74) * reader to try-with-resource (osmlab#80) * Fix bug (osmlab#82) * Unusual Layer Tag Bug Fix & Enhancement (osmlab#83) * fix unit tests, junction logic, and bridges * update instructions; add config * add author * use unused test atlases * increase version after release (osmlab#84) * update atlas dependencies (osmlab#85) update atlas to 5.2.0, atlas_generator to 4.0.10 * increase version number after release (osmlab#86) * update atlas version to 5.2.1 (osmlab#90) to include the fix for PR-256 * Update gradle.properties (osmlab#91) * lowercase l (osmlab#92) * fix enum bug (osmlab#88) * EdgeCrossingEdgeCheck Bug Fix & Enhancements (osmlab#93) * fix unit tests and layer logic * add highway minimum config * add walker * code cleanup * highway.get() once * declaire type * FBS to helper * address pr comments * use EdgeWalker * Update atlas version (osmlab#97) * Building Road Intersection Check Enhancement (osmlab#94) * Add enhancements * Enhancements to capture nodes within building/edges * Code refactor * Include all highways instead of service * Add configurable highway filter * Code refactor * Code refactor * Remove extra line * Update Java doc * Update configuration * Revert unit test changes * Remove extra line * Update java doc and configurable key * Update node to point in java doc * Refactor code to address PR comments * Update access tag filter * Resolve PR comments * increment version (osmlab#96) * Generator update (osmlab#99) * Update atlas version * Update atlas generator * increment version to 4.0.9 * Atlas-checks version update (osmlab#100) * Update atlas version * Update atlas generator * increment version to 4.0.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The main change in this PR stemmed from a bug created by a change of a LayerTag method (see #77). To fix this issue the check has been changed to no longer check all Edges with junction tags.
This bug should have been caught by the unit tests, but were missed due to a lack of car navigable highway tags. Unit test have been updated to address this.
Also included in this PR are a change of the instructions, and adding the check to the configuration file. The instruction change just removes an unnecessary mention of edges.
Potential Impact:
Remove a large number of false positives.
Unit Test Approach:
Unit tests were updated so that all edges have car navigable highway tags. This prevents them from being filtered out in
validCheckForObject.A unit test was updated to check for the correct instruction.
4 unit tests were added to use 4 existing, unused Test Atlases for junctions.
Test Results:
Testing showed false positive rates dropped back to expected levels after the fix.