Update SignPostCheck with off/on ramp specific logic #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgcuthbert
approved these changes
Mar 13, 2018
mgcuthbert
pushed a commit
to mgcuthbert/atlas-checks
that referenced
this pull request
Apr 16, 2018
commit 95792b9 Author: Michael Cuthbert <[email protected]> Date: Tue Mar 20 08:54:00 2018 -0700 Merging dev branch from open source (osmlab#79) * Remove SparkFileHelper, SparkFileOutput, SparkFilePath and reference the ones in atlas-generator (osmlab#22) * Configuration overrides for countries and groups of countries in Integrity Checks (osmlab#20) * Override for groups and countires in Integrity Checks Configuration * reformat * Update Dependency for Atlas Checks to Enable Build * Changes made for better logging and validating * Changes made for reviewers * Adding UnusualLayerTagCheck * Adding UnusualLayerTagCheck (osmlab#24) * Update SignPostCheck with off/on ramp specific logic (osmlab#25) * Roundabout Valence Check (osmlab#26) * ok * okay * fixing commits * still fixing commits * rolling forward again * roll forward * rolling forward * roll forward * removed some conditionals as the data structures inherently check these * updated function name to make it more clear * get master edge * updates as per danielduhh * removed Message Format import * formatting long in instructions; handle 2 way roundabouts * fixed string for space in instructions * change for car navigable edges to count toward valence only * remove extra lines * updates to unit tests to account for car navigable roads * updates to the documentation and made a lambda into reference method * fix for config values * fix config max threshold to 14 * remove ghana file * changes to comments to include greater than or equal to and info about configuration; * set upper in code to 10 * moved to linear.edges, add unit tests * ok * okay * fixing commits * still fixing commits * rolling forward again * roll forward * rolling forward * roll forward * removed some conditionals as the data structures inherently check these * updated function name to make it more clear * get master edge * updates as per danielduhh * removed Message Format import * formatting long in instructions; handle 2 way roundabouts * fixed string for space in instructions * change for car navigable edges to count toward valence only * remove extra lines * updates to unit tests to account for car navigable roads * updates to the documentation and made a lambda into reference method * fix for config values * fix config max threshold to 14 * remove ghana file * changes to comments to include greater than or equal to and info about configuration; * set upper in code to 10 * moved to linear.edges, add unit tests * added challenge information * changes to config * refactoring of flag and getAllRoundaboutEdge methods; updates to unit tests * flag roundabout and not connected non-roundabout edges when valence is 1 * updated link in documentation * updated input params for getAllRoundaboutEdges in docs * updates to variables, preliminary filtering * gradle build fix * SelfIntersectingPolylineCheck enhancements (osmlab#23) * updated check requirements detailed instructions * clean up tests & variables/comments * variable name cleaup * typo * utilize configuration for filtering ineligible highway tags incorporate configuration in unit tests * move eligible highways filter to configuration * refactor unit tests for extensibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
SignPostCheckfor flexibility and easier maintenance. In addition to off ramps, now on ramps are flagged as well. However, on-ramps are treated differently and their start location is found and flagged rather than where they connect to highway.missingTagsandoffendingObjectssets that were used to track objects and tags. I am now relying onCheckFlagclass directly. At the end, if instance doesn't have anything flagged, we'll skip flag operation.CheckFlagclass. MethodsaddObjectandaddObjectshad different behavior. I updatedaddObjectsto calladdObject.