AreasWithHighwayTagsCheck enhancements #109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a series of enhancements to AreasWithHighwayTagsCheck.
In short, the new logic is as follows: for any area or edge, if that object has an area=yes tag and a highway tag that is not one of
{services, service, rest area, pedestrian, platform}
, flag it and all connected edges that share a similar problem.Potential Impact:
Changed flag counts for AreasWithHighwayTags.
Unit Test Approach:
Added unit tests to cover edges and a couple of new area cases.
Test Results:
All tests passing.