Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AreasWithHighwayTagsCheck enhancements #109

Merged
merged 11 commits into from
Jan 17, 2019

Conversation

nachtm
Copy link
Contributor

@nachtm nachtm commented Dec 13, 2018

Description:

This is a series of enhancements to AreasWithHighwayTagsCheck.

  • Previously, only areas were being checked. This missed out on a large number of OSM ways that were tagged with area=yes and some invalid highway value.
  • In addition, there are some highway tags that are valid in conjunction with area=yes that were previously being flagged. Those are no longer flagged.
  • Finally, instead of just flagging the particular edge in question, we gather all connected edges with improper combinations of area and highway tags. This makes the output of this check easier to understand for people who are familiar with OSM but not Atlas. This may also reduce the flag count in some cases, since connected improperly tagged edges will be flagged as a single unit now.

In short, the new logic is as follows: for any area or edge, if that object has an area=yes tag and a highway tag that is not one of {services, service, rest area, pedestrian, platform}, flag it and all connected edges that share a similar problem.

Potential Impact:

Changed flag counts for AreasWithHighwayTags.

Unit Test Approach:

Added unit tests to cover edges and a couple of new area cases.

Test Results:

All tests passing.

Copy link
Collaborator

@jklamer jklamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One clean up ask. Looks good.

@yiqingj yiqingj merged commit 58e5883 into osmlab:dev Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants