Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix support for pipx #286

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented May 13, 2024

Pull Request description

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@xmnlab xmnlab marked this pull request as ready for review May 13, 2024 03:14
Copy link
Contributor

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, @xmnlab! I can confirm that this is working for me on a macOS machine (I do not have a Windows machine handy right now to test this, however). Your speed with which you looked into this and our correspondence over the past few days is really appreciated.

Edit; adding the reviewer's checklist below:

  • I managed to reproduce the problem locally from the main branch
  • I managed to test the new changes locally
  • I confirm that the issues mentioned were fixed/resolved

@agriyakhetarpal
Copy link
Contributor

Note: I tested with pipx install based on a discussion from this thread: pypa/pipx#812, let me test with pipx run as well.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @xmnlab! This looks good to me!

@xmnlab
Copy link
Member Author

xmnlab commented May 13, 2024

thanks @agriyakhetarpal and @Saransh-cpp for the review! appreciate that.

@agriyakhetarpal , I didn't test it with pipx install, just with the pipx run, so I think we are good to merge this :)
but feel free to ping me if you have any issue!

@xmnlab xmnlab merged commit 0e5b125 into osl-incubator:main May 13, 2024
16 checks passed
@xmnlab xmnlab deleted the change-npx-to-api-call branch May 13, 2024 16:09
Copy link

🎉 This PR is included in version 0.8.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants