feat: Moved UpdateRequestId to Options.

oscoreio · Feb 16, 2024 · adb7a4c · adb7a4c
1 parent e14f151
commit adb7a4c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/src/libs/Directory.Build.props b/src/libs/Directory.Build.props
@@ -9,7 +9,7 @@
  </ItemGroup>
 
  <PropertyGroup Label="Nuget">
- <Version>1.0.0</Version>
+ <Version>1.0.1</Version>
  <GeneratePackageOnBuild Condition=" '$(Configuration)' == 'Release' ">true</GeneratePackageOnBuild>
  <GenerateDocumentationFile>true</GenerateDocumentationFile>
  <Authors>Oscore</Authors>

diff --git a/src/libs/Maui.Android.InAppUpdates/AndroidInAppUpdatesOptions.cs b/src/libs/Maui.Android.InAppUpdates/AndroidInAppUpdatesOptions.cs
@@ -22,6 +22,12 @@ public class AndroidInAppUpdatesOptions
  /// </summary>
  public bool UseFakeAppUpdateManager { get; set; }
 
+ /// <summary>
+ /// This value is used to differentiate between multiple update or request processes within your app. <br/>
+ /// To avoid intersection with other libraries or request codes, choose a unique value within your application context.
+ /// </summary>
+ public int UpdateRequestId { get; set; } = 4711;
+
  /// <summary>
  /// This action will be triggered when the app is updated. <br/>
  /// Default action will show the toast with english text. <br/>

diff --git a/src/libs/Maui.Android.InAppUpdates/Platforms/Android/Handler.cs b/src/libs/Maui.Android.InAppUpdates/Platforms/Android/Handler.cs
@@ -14,8 +14,6 @@ namespace Maui.Android.InAppUpdates.Internal;
 /// </summary>
 public static class Handler
 {
- public const int RequestUpdate = 4711;
-
  /// <summary>
  /// The app update manager.
  /// </summary>
@@ -45,7 +43,7 @@ public static void HandleCreate(Activity activity, Bundle? savedInstanceState)
  AppUpdateSuccessListener ??= new AppUpdateSuccessListener(
  appUpdateManager: AppUpdateManager,
  activity: activity,
- updateRequest: RequestUpdate);
+ updateRequest: Options.UpdateRequestId);
  AppUpdateManager.AppUpdateInfo.AddOnSuccessListener(AppUpdateSuccessListener);
  }
 
@@ -63,7 +61,7 @@ public static void HandleResume(Activity activity)
  ResumeSuccessListener ??= new ResumeSuccessListener(
  appUpdateManager: AppUpdateManager,
  activity: activity,
- updateRequest: RequestUpdate);
+ updateRequest: Options.UpdateRequestId);
  AppUpdateManager.AppUpdateInfo.AddOnSuccessListener(ResumeSuccessListener);
  }
 
@@ -80,7 +78,7 @@ public static void HandleActivityResult(
  [GeneratedEnum] Result resultCode,
  Intent? data)
  {
- if (requestCode != RequestUpdate)
+ if (requestCode != Options.UpdateRequestId)
  {
  return;
  }