Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option handling, fix #808 #810

Merged
merged 12 commits into from
Jun 29, 2024
Merged

option handling, fix #808 #810

merged 12 commits into from
Jun 29, 2024

Conversation

hannes14
Copy link
Member

Some options in Singular are local to the "current ring" (OPT_INTSTRATEGY,OPT_REDTHROUGH,OPT_REDTAIL,OPT_REDTAIL_SYZ). In Singular.jl there is no "current ring": modified ring change to keep tghe current (global) setting of options except the needed changes due to the properties of a ring.

Some options in Singular are local to the "current ring"
(OPT_INTSTRATEGY,OPT_REDTHROUGH,OPT_REDTAIL,OPT_REDTAIL_SYZ).
In Singular.jl there is no "current ring": modified ring change
to keep tghe current (global) setting of options except the
needed changes due to the properties of a ring.
deps/src/singular.cpp Outdated Show resolved Hide resolved
deps/src/singular.cpp Outdated Show resolved Hide resolved
@fingolfin fingolfin closed this Jun 27, 2024
@fingolfin fingolfin reopened this Jun 27, 2024
deps/src/singular.cpp Outdated Show resolved Hide resolved
@hannes14 hannes14 requested a review from fingolfin June 28, 2024 14:59
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some final tweaks, will set to automerge

@hannes14 hannes14 merged commit 8a4d1d1 into oscar-system:master Jun 29, 2024
12 of 14 checks passed
@hannes14 hannes14 deleted the hs/options branch June 29, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants