Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade OTEL #808

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: upgrade OTEL #808

wants to merge 2 commits into from

Conversation

vivshankar
Copy link

Given the request made in ory/fosite#809, this PR proposes upgrading the OTEL modules to the latest version (v1.29.0).

Related Issue or Design Document

ory/fosite#809

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

N/A

@zepatrik zepatrik requested a review from alnr September 9, 2024 09:18
@alnr
Copy link
Contributor

alnr commented Sep 9, 2024

In the past, opentelemetry regularly introduces backwards-incompatible changes to their SDKs in minor releases. Have you checked if Hydra+Keto+Kratos+Oathkeeper work with this new version?

@vivshankar
Copy link
Author

@alnr I have tested with Fosite's unit tests and haven't seen any issues. I have not tried this with Hydra or the other products. I don't have those running locally.

@vivshankar
Copy link
Author

@alnr Can this move forward? I have tested this with Fosite and it works.

@alnr
Copy link
Contributor

alnr commented Sep 13, 2024

I don't have capacity right now to verify this doesn't cause upgrade issues in kratos/keto/hydra/oathkeeper.

@vivshankar
Copy link
Author

Interestingly, Hydra is already at v1.28 - https://github.com/ory/hydra/blob/master/go.mod#L60C2-L63C40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants