This repository has been archived by the owner on Oct 8, 2018. It is now read-only.
Fixes: #7 - don't escape username and password #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Wilkins <[email protected]>
|
Thanks! Could you also please add a test? |
aeneasr
reviewed
Sep 1, 2018
connector.go
Outdated
|
|
||
| userinfo := c.URL.User.Username() | ||
| if password, hasPassword := c.URL.User.Password(); hasPassword { | ||
| userinfo = userinfo + ":" + password |
There was a problem hiding this comment.
Does this work when userinfo or password have a :?
There was a problem hiding this comment.
This works when password has a :, but fails when username does. It looks like this is related to go-sql-driver/mysql#591 - their DSN parser doesn't support it.
There was a problem hiding this comment.
to be clear, the existing implementation also fails when the username has a :, and this does not fix that. this does fix when the username or password has certain other characters
Signed-off-by: David Wilkins <[email protected]>
davidjwilkins
force-pushed
the
master
branch
from
6079115
to
ac45750
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.