Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh flow: prevent accidentially returned token #708

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sja
Copy link

@sja sja commented Oct 5, 2022

In case the transaction commit fails, the responder reference was already modified which could result in a token returned which was not persisted.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

In case the transaction commit fails, the responder reference was already modified which could result in a token returned which was not persisted.
@mitar
Copy link
Contributor

mitar commented Feb 15, 2024

Can you add tests for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants