Spreadsheet: Prevent infinite loop in Range ctor

orospakr · Feb 20, 2022 · b3591d2 · b3591d2
1 parent 54b4eb6
commit b3591d2
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/Base/res/js/Spreadsheet/runtime.js b/Base/res/js/Spreadsheet/runtime.js
@@ -162,6 +162,9 @@ class Ranges {
 
 class Range {
  constructor(startingColumnName, endingColumnName, startingRow, endingRow, columnStep, rowStep) {
+ // using == to account for '0' since js will parse `+'0'` to 0
+ if (columnStep == 0 || rowStep == 0)
+ throw new Error("rowStep or columnStep is 0, this will cause an infinite loop");
  this.startingColumnName = startingColumnName;
  this.endingColumnName = endingColumnName;
  this.startingRow = startingRow;