-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Workflow Runs #281
base: main
Are you sure you want to change the base?
Conversation
5c49ace
to
25a35ae
Compare
I feel like the test for this may suffer from the same problem as this one solves 🙂
|
I've split the workflows in the same manner as my PR recommends in terms of usage. It is notable that for this PR, coverage won't run, as the workflow needs to be in the default branch before it will become an action that can be triggered. |
@orgoro anything extra required for merge? I've been using my fork in my own workflows for a while now 🙂 |
@techman83 - thanks for putting this together. I tried it out but ran into an error: https://github.com/posit-dev/posit-sdk-py/actions/runs/9353058789 It looks like the 'base' variable is undefined, which I believe stems from here: https://github.com/orgoro/coverage/pull/281/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R19 I tried to determine the shape of Any thoughts or advice is appreciated. Thanks! |
@tdstein I'm not really sure, it has been working pretty reliably for most of my testing The payload is what is in the Would need a sample of the github to get a better idea. Which you can dump using echo - run: echo "${{ toJson(github) }}" It would be nice if actions/core had a workflow type that could be consumed, but that extended well beyond my available time for such things 🙂 |
Due to security issues running untrusted checkouts from forks, access to things like secrets and tokens are blocked. It is possible to allow this, but it is not wise, and the recommended process is to use a workflow run call. This will add support for workflow_run based pull requests, allowing PRs to be commented upon, regardless of whether they are a fork or from a local branch. fixes orgoro#259
Cover workflow fails for the same reason as this PR is attempting to resolve. Splitting them in the same manner.
6aed45b
to
67c99eb
Compare
Rebased off current main 🙂 |
Due to security issues running untrusted checkouts from forks, access to things like secrets and tokens are blocked. It is possible to allow this, but it is not wise, and the recommended process is to use a workflow run call. This will add support for workflow_run based pull requests, allowing PRs to be commented upon, regardless of whether they are a fork or from a local branch.