Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make settings public #3768

Merged
merged 1 commit into from
May 20, 2024
Merged

Make settings public #3768

merged 1 commit into from
May 20, 2024

Conversation

raphjaph
Copy link
Collaborator

@raphjaph raphjaph commented May 20, 2024 •
edited
Loading

Fixes #3764

@raphjaph raphjaph mentioned this pull request May 20, 2024
Closed
casey
casey approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphjaph raphjaph merged commit a3cd33e into ordinals:master May 20, 2024
5 checks passed
@ynohtna92
Copy link
Contributor

Settings still can't be used publicly with use ord::settings::Settings; as the setting mod is private where it is defined https://github.com/ordinals/ord/blob/master/src/lib.rs#L118

@raphjaph
Copy link
Collaborator Author

raphjaph commented Jun 6, 2024

#3800

@ynohtna92
Copy link
Contributor

#3800

Thanks, saw that it was just recently merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casey casey casey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events Settings are private?
3 participants
@raphjaph @ynohtna92 @casey