Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List transaction outputs #292

Merged
merged 12 commits into from
Aug 7, 2022
Merged

List transaction outputs #292

merged 12 commits into from
Aug 7, 2022

Conversation

terror
Copy link
Contributor

@terror terror commented Aug 5, 2022

No description provided.

@casey casey marked this pull request as ready for review August 6, 2022 20:48
@casey
Copy link
Collaborator

casey commented Aug 7, 2022

I think this is ready to go, feel free to merge if you agree. I did a few things:

  • Bitcoin datadir needed Bitcoin added to it on Linux
  • The map vs string issue was because getrawtransactions returns hex when verbose is false
  • Update to redb 0.5.0, which automatically aborts transactions on drop, so we won't get that leaked write transaction warning (see Leaked write transactions are hard to avoid cberner/redb#320)

@casey
Copy link
Collaborator

casey commented Aug 7, 2022

I added and then removed a wrapper, AbortOnDrop, but post 0.5.0 we don't need it so I removed it.

@terror terror merged commit 7be76b0 into master Aug 7, 2022
@terror terror deleted the outputs branch August 7, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants