Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to decompress brotli server-side #2854

Merged
merged 18 commits into from
Dec 12, 2023
Merged

Add flag to decompress brotli server-side #2854

merged 18 commits into from
Dec 12, 2023

Conversation

raphjaph
Copy link
Collaborator

No description provided.

casey
casey reviewed Dec 12, 2023
View reviewed changes
docs/src/guides/testing.md Outdated Show resolved Hide resolved
casey
casey requested changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random comments.

docs/src/guides/testing.md Outdated Show resolved Hide resolved
src/subcommand/server.rs Outdated Show resolved Hide resolved
src/subcommand/server.rs Outdated Show resolved Hide resolved
src/subcommand/server.rs Outdated Show resolved Hide resolved
src/subcommand/server.rs Outdated Show resolved Hide resolved
@raphjaph
Copy link
Collaborator Author

I combined PageConfig and ServerConfig inside ServerConfig

@raphjaph
Copy link
Collaborator Author

Acceptability shouldn't be checked since browsers won't set it if connecting via HTTP

@casey
Copy link
Collaborator

casey commented Dec 12, 2023

Acceptability shouldn't be checked since browsers won't set it if connecting via HTTP

I don't think I understand. We can check it anyways, since if it isn't set, we can just decmpress.

casey
casey requested changes Dec 12, 2023
View reviewed changes
docs/src/guides/testing.md Outdated Show resolved Hide resolved
docs/src/guides/testing.md Outdated Show resolved Hide resolved
src/server_config.rs Outdated Show resolved Hide resolved
src/server_config.rs Outdated Show resolved Hide resolved
src/subcommand/server.rs Outdated Show resolved Hide resolved
src/subcommand/server.rs Outdated Show resolved Hide resolved
src/subcommand/server.rs Outdated Show resolved Hide resolved
src/subcommand/server.rs Outdated Show resolved Hide resolved
@raphjaph
Copy link
Collaborator Author

raphjaph commented Dec 12, 2023 •
edited
Loading

Acceptability shouldn't be checked since browsers won't set it if connecting via HTTP

I don't think I understand. We can check it anyways, since if it isn't set, we can just decmpress.

If we are decompressing, the data will not be encoded so we shouldn't set the CONTENT_ENCODING header. Even if the client sets br in the request header we don't care since we are decompressing. But maybe I'm understanding something wrong.

casey
casey approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment. Otherwise looks good.

src/subcommand/server.rs Outdated Show resolved Hide resolved
@raphjaph @casey
Update src/subcommand/server.rs
6f71796 
Co-authored-by: Casey Rodarmor <[email protected]>
@casey
Copy link
Collaborator

casey commented Dec 12, 2023

lgtm

@raphjaph raphjaph enabled auto-merge (squash) December 12, 2023 04:06
@raphjaph raphjaph merged commit 6115eca into master Dec 12, 2023
6 checks passed
@raphjaph raphjaph deleted the decompress-brotli branch December 12, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casey casey casey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raphjaph @casey