Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Jubilee: uncurse new inscriptions after jubilee height #2656

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Nov 10, 2023

Fixes #2495.

Script for calculating height:

#!/usr/bin/env python3

import math

def jubilee_height(current_height, adjustments):
  next_adjustment = math.ceil(current_height / 2016)
  activation_adjustment = next_adjustment + adjustments
  activation_height = activation_adjustment * 2016
  return activation_height

print("mainnet:", jubilee_height(819059, 2))
print("signet:", jubilee_height(171496, 1))
print("testnet:", jubilee_height(2541003, 1))

@casey casey mentioned this pull request Nov 10, 2023
@casey casey marked this pull request as draft November 10, 2023 02:03
@gmart7t2
Copy link
Contributor

This looks like new inscriptions with unrecognized even fields won't be cursed going forward. Is that the case? And if so, is that intended?

I would expect that we want unrecognized even fields to be cursed indefinitely.

@casey
Copy link
Collaborator Author

casey commented Nov 14, 2023

That's correct. Inscriptions with unrecognized even fields will still be unbound, so they don't have a location, but not cursed.

@adanamanya
Copy link

release the beast

@rot13maxi
Copy link
Contributor

my body is ready

@rot13maxi
Copy link
Contributor

Assuming 144 blocks per day, we’re now within two weeks of the activation height in this pr. I notice it’s still marked as a draft. @casey how are you feeling about it?

@casey
Copy link
Collaborator Author

casey commented Nov 28, 2023

I think we should definitely give it minimum two weeks, and I'd like to do it on a difficulty adjustment, for style points, so it'll probably wind up being later.

@casey casey force-pushed the jubilee branch 4 times, most recently from eddfa07 to 566a32a Compare November 30, 2023 01:48
@casey casey marked this pull request as ready for review November 30, 2023 01:49
@casey casey force-pushed the jubilee branch 2 times, most recently from 20ef719 to 68e0396 Compare November 30, 2023 02:04
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is forgiven 💸

@casey casey enabled auto-merge (squash) November 30, 2023 02:16
@casey casey merged commit 78f10da into ordinals:master Nov 30, 2023
6 checks passed
@casey casey deleted the jubilee branch November 30, 2023 02:18
thedoublejay pushed a commit to sadoprotocol/ord that referenced this pull request Dec 1, 2023
* Fix lost sats bug (ordinals#2666)

* Add Hindi version of handbook (ordinals#2648)

* Remove Index::index_block_inscription_numbers (ordinals#2667)

* Hide protocol inscriptions (ordinals#2674)

* Don't color links in headers (ordinals#2678)

* Add inscription charms (ordinals#2681)

* Group rune server tests (ordinals#2685)

* Add inscription compression (ordinals#1713)

* Fix media table formatting (ordinals#2686)

* Update schema version for charms (ordinals#2687)

* Fix unbound outpoint server error (ordinals#2479)

* Add binary media type (ordinals#2671)

* Clean up install.sh (ordinals#2669)

* Add /collections Page (ordinals#2561)

* Preview font inscriptions (ordinals#2692)

* Only load used language highlight module in code preview (ordinals#2696)

* Only try to create the database if it wasn't found (ordinals#2703)

* Move postage into batch file (ordinals#2705)

* Add destination field to batch (ordinals#2701)

* Use sequence numbers database keys (ordinals#2664)

* Update redb to 1.4.0 (ordinals#2714)

* Refactor inscriptions paginations (ordinals#2715)

* Display table stats in `ord index info` (ordinals#2711)

* Use redb's recovery callback API (ordinals#2584)

* Allow setting CSP origin (ordinals#2708)

* Remove default file path from `ord index export --tsv` (ordinals#2717)

* Use icons in nav bar (ordinals#2722)

* Add Debian packaging instructions (ordinals#2725)

* Add Homebrew install instructions to readme (ordinals#2726)

* Add sat recursive endpoints with index and pagination (ordinals#2680)

* Only accept sat number in recursive endpoint (ordinals#2732)

* Fix typo in docs/src/inscriptions/metadata.md (ordinals#2731)

* Add docs for metadata recursive endpoint (ordinals#2734)

* Remove `RUNE` from <h1> on /rune (ordinals#2728)

* Add /r/children recursive endpoint (ordinals#2431)

* Add docs and examples for sat recursive endpoint (ordinals#2735)

* Ignore flaky test (ordinals#2742)

* Update docs to include all fields, including content-encoding (ordinals#2740)

* Add docs for child recursive endpoint (ordinals#2743)

* Hide JSON and .btc (ordinals#2744)

* Release 0.12.0 (ordinals#2746)

* Hide all text (ordinals#2753)

* Add batch to preview command (ordinals#2752)

* Add stuttering curse (ordinals#2745)

* Batch inscribe on same sat (ordinals#2749)

* Allow setting the sat to inscribe (ordinals#2765)

* Select further away coins which meet target (ordinals#2724)

* Fix typos (ordinals#2768)

* Add ability to specify sat to batch inscribe (ordinals#2770)

* Add commands to etch and list runes (ordinals#2544)

* Set CSP origin in deploy script (ordinals#2764)

Co-authored-by: raph <[email protected]>

* Add `public` to /content Cache-Control headers (ordinals#2773)

* Release 0.12.1 (ordinals#2776)

* Bless cursed inscriptions after Jubilee height (ordinals#2656)

* Hide /content/<INSCRIPTION_ID> HTML inscriptions (ordinals#2778)

* Release 0.12.2 (ordinals#2780)

* fix(test): error test from version 0.12.2

---------

Co-authored-by: raph <[email protected]>
Co-authored-by: duttydeedz <[email protected]>
Co-authored-by: Casey Rodarmor <[email protected]>
Co-authored-by: liam <[email protected]>
Co-authored-by: Eloc <[email protected]>
Co-authored-by: Julian Eager <[email protected]>
Co-authored-by: ordinally <[email protected]>
Co-authored-by: Christopher Berner <[email protected]>
Co-authored-by: Rijndael <[email protected]>
Co-authored-by: vuittont60 <[email protected]>
Co-authored-by: gmart7t2 <[email protected]>
Co-authored-by: xiaolou86 <[email protected]>
@dami025
Copy link

dami025 commented Dec 31, 2023

New inscription?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Jubilee
6 participants