Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate calculate_sat logic #2402

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Deduplicate calculate_sat logic #2402

merged 4 commits into from
Aug 31, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Aug 30, 2023

Fixes #2210

@casey casey changed the title Deduplciate calculate_sat logic Deduplicate calculate_sat logic Aug 30, 2023
veryordinally
veryordinally approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@veryordinally veryordinally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge

@casey casey enabled auto-merge (squash) August 31, 2023 19:23
@casey casey disabled auto-merge August 31, 2023 19:23
@casey casey enabled auto-merge (squash) August 31, 2023 19:23
@casey casey merged commit 9b8a4bf into ordinals:master Aug 31, 2023
6 checks passed
@casey casey deleted the deduplicate-calculate-sat branch August 31, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veryordinally veryordinally veryordinally approved these changes

@raphjaph raphjaph Awaiting requested review from raphjaph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove code duplication for calculate_sat (with code in update_inscription_location)
2 participants
@casey @veryordinally