Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show text inscriptions on homepage #1058

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Show text inscriptions on homepage #1058

merged 2 commits into from
Dec 23, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Dec 22, 2022

I think this is worth doing, even if they're a little awkward looking. We want people to know that text inscriptions are possible.

@casey casey requested a review from raphjaph December 22, 2022 23:30
raphjaph
raphjaph approved these changes Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of overlap with #1058 but looks good.

@raphjaph raphjaph mentioned this pull request Dec 23, 2022
Closed
@casey casey linked an issue Dec 23, 2022 that may be closed by this pull request
Allow text inscriptions on homepage #1050
Closed
@casey casey enabled auto-merge (squash) December 23, 2022 19:06
@casey casey merged commit 3fb0af2 into master Dec 23, 2022
@casey casey deleted the show-text branch December 23, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow text inscriptions on homepage
2 participants
@casey @raphjaph