Skip to content

Commit

Permalink
chore!: Remove deprecated argocd-applicationset and argocd-notificati…
Browse files Browse the repository at this point in the history
…ons (argoproj#1237)

Signed-off-by: Marco Kilchhofer <[email protected]>
  • Loading branch information
mkilchhofer committed Apr 22, 2022
1 parent 93274f5 commit 39bd0e1
Show file tree
Hide file tree
Showing 43 changed files with 2 additions and 8,751 deletions.
2 changes: 0 additions & 2 deletions .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ body:
- argo-events
- argo-rollouts
- argo-workflows
- argocd-applicationset
- argocd-image-updater
- argocd-notifications
- other
validations:
required: true
Expand Down
2 changes: 0 additions & 2 deletions .github/ISSUE_TEMPLATE/feature_request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ body:
- argo-events
- argo-rollouts
- argo-workflows
- argocd-applicationset
- argocd-image-updater
- argocd-notifications
- other
validations:
required: true
Expand Down
3 changes: 1 addition & 2 deletions .github/configs/ct-install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,4 @@ validate-chart-schema: false
validate-maintainers: true
validate-yaml: true
exclude-deprecated: true
excluded-charts:
- "argocd-applicationset"
excluded-charts: []
4 changes: 1 addition & 3 deletions .github/workflows/lint-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@ jobs:

- name: Deploy latest ArgoCD CRDs when testing ArgoCD extensions
if: |
contains(steps.list-changed.outputs.changed_charts, 'argocd-applicationset') ||
contains(steps.list-changed.outputs.changed_charts, 'argocd-image-updater') ||
contains(steps.list-changed.outputs.changed_charts, 'argocd-notifications')
contains(steps.list-changed.outputs.changed_charts, 'argocd-image-updater')
run: |
kubectl apply -f charts/argo-cd/crds
Expand Down
3 changes: 0 additions & 3 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,3 @@

# Argo Rollouts
/charts/argo-rollouts/

# Argo CD Notifications
/charts/argocd-notifications/ @alexmt @andyfeller @mbevc1
10 changes: 0 additions & 10 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,16 +119,6 @@ argocd app create guestbook --dest-namespace default --dest-server https://kuber
argocd app sync guestbook
```

## Testing Argo CD Notification Changes

Thorough testing of argocd-notifications would require one or more notification services (Slack, OpsGenie, etc), however
minimal testing mostly consists of successful Helm chart installation and the argocd-notifications controller having
access to the `Application` resources in the same namespace that Argo CD is installed.

```
helm install argocd-notifications charts/argocd-notifications --namespace argocd
```

## New Application Versions

When raising application versions ensure you make the following changes:
Expand Down
25 changes: 0 additions & 25 deletions charts/argocd-applicationset/.helmignore

This file was deleted.

18 changes: 0 additions & 18 deletions charts/argocd-applicationset/Chart.yaml

This file was deleted.

121 changes: 0 additions & 121 deletions charts/argocd-applicationset/README.md

This file was deleted.

58 changes: 0 additions & 58 deletions charts/argocd-applicationset/README.md.gotmpl

This file was deleted.

6 changes: 0 additions & 6 deletions charts/argocd-applicationset/ci/default-values.yaml

This file was deleted.

9 changes: 0 additions & 9 deletions charts/argocd-applicationset/ci/leader-election-values.yaml

This file was deleted.

7 changes: 0 additions & 7 deletions charts/argocd-applicationset/ci/servicemonitor-values.yaml

This file was deleted.

Loading

0 comments on commit 39bd0e1

Please sign in to comment.