Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LIBFFI to 3.4.6 #9124

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Jun 17, 2024

Note that this currently prints:

Error downloading from https://lafo.ssw.uni-linz.ac.at/pub/graal-external-deps/libffi-3.4.6.tar.gz to /home/zakkak/.mx/cache/LIBFFI_SOURCES_033d2600e879b83c6bce0eb80f69c5f32aa775bf2e962c9d39fbd21226fa19d1e79173d8eaa0d0157014d54509ea73315ad86842356fc3a303c0831c94c6ab39/libffi-sources.tar.gz: HTTP Error 404: Not Found

during the build, due to libffi-3.4.6 not being mirrored in https://lafo.ssw.uni-linz.ac.at/pub/graal-external-deps/ but it successfully fetches it from the upstream github repository.

Also note that this has not been tested on windows, so the windows patch file might need further adjustments.

Fixes #9123

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 17, 2024
@zakkak zakkak requested a review from rschatz June 17, 2024 09:25
@rschatz rschatz self-assigned this Jun 20, 2024
Copy link
Member

@rschatz rschatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

I'll have a look at the windows patch. It doesn't apply cleanly. I'll figure out how to regenerate it, shouldn't be that hard.

@graalvmbot graalvmbot merged commit dc03de2 into oracle:master Jul 10, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraalVM fails to build on Fedora 40 with gcc 14.1.1 due to unresolved issue in libffi 3.4.4
3 participants