Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-52456] Add nightly workflow for Spring. #8510

Merged
merged 10 commits into from
Mar 5, 2024

Conversation

graalvmbot
Copy link
Collaborator

and refactor other microservices workflows.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 4, 2024
@fniephaus fniephaus requested a review from zakkak March 4, 2024 10:13
export JAVA_HOME=${LABSJDK_HOME}
cd substratevm
${MX_PATH}/mx --native=native-image,lib:jvmcicompiler --components="Native Image,LibGraal" build
mv $(${MX_PATH}/mx --native=native-image,lib:jvmcicompiler --components="Native Image,LibGraal" graalvm-home) ${GRAALVM_HOME}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shared action no longer builds libgraal. It's actually not used when running a Native Image build.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting. When did that change? Last time I checked libgraal was being used by GraalVM CE see graalvm#288 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing changed, what I meant is that the compilation stage in Native Image uses jargraal anyway (it adds additional AOT-specific phases etc that would otherwise require recompilation of libgraal). Yes, libgraal would probably improve performance a bit when compiling jargraal, but building it probably takes more time in CI than it saves.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so if I get this right:

  • It's still being used (if present) by the native-image generator (the java process which runs on GraalVM) but it's just used to run that process and is not being used to AOT compile the native image.

  • Since GraalVM with libgraal is being tested extensively in other places there is no reason for testing it in this context as well.

- name: Run nativeTest in spring-petclinic
run: |
cd ${{ env.SPRING_PETCLINIC_PATH }}
./gradlew nativeTest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @sdeleuze

@graalvmbot graalvmbot closed this Mar 5, 2024
@graalvmbot graalvmbot deleted the fniephaus/GR-52456/spring-gate branch March 5, 2024 13:28
@graalvmbot graalvmbot merged commit 82e9cd6 into master Mar 5, 2024
66 checks passed
@fniephaus fniephaus restored the fniephaus/GR-52456/spring-gate branch March 5, 2024 16:05
@graalvmbot graalvmbot deleted the fniephaus/GR-52456/spring-gate branch March 5, 2024 16:08
@fniephaus fniephaus restored the fniephaus/GR-52456/spring-gate branch March 5, 2024 16:25
@graalvmbot graalvmbot deleted the fniephaus/GR-52456/spring-gate branch March 5, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants