Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GR-44722] Make vendor version adjustable at build-time. #6356

Merged
merged 4 commits into from
Apr 4, 2023
Merged

[GR-44722] Make vendor version adjustable at build-time. #6356

merged 4 commits into from
Apr 4, 2023

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Apr 4, 2023 •
edited by fniephaus
Loading

This also adjusts the build output and fixes a JMX bug.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 4, 2023
@fniephaus fniephaus requested review from jerboaa and zakkak April 4, 2023 07:27
@fniephaus fniephaus linked an issue Apr 4, 2023 that may be closed by this pull request
[native-image --version] No way to tell version in use when JDK isn't jlinked nor compiled to binary #6319
Closed
@fniephaus fniephaus mentioned this pull request Apr 4, 2023
Closed
jerboaa
jerboaa approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I've tested it as well and it works for our use-cases.

@jerboaa jerboaa mentioned this pull request Apr 4, 2023
Closed
@fniephaus
Copy link
Member

LGTM, thanks! I've tested it as well and it works for our use-cases.

Perfect! Thanks for checking. :)

This was referenced Apr 4, 2023
Merged
Closed
@zakkak zakkak mentioned this pull request Apr 4, 2023
Merged
3 tasks
@graalvmbot graalvmbot merged commit f7d9d2f into master Apr 4, 2023
@graalvmbot graalvmbot deleted the fniephaus/GR-44722/vendor-version-fix branch April 4, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerboaa jerboaa jerboaa approved these changes

@zakkak zakkak zakkak left review comments

@fniephaus fniephaus fniephaus left review comments

Assignees

@fniephaus fniephaus

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
GraalVM for JDK 17 / JDK 20 (June 13,...
Development

Successfully merging this pull request may close these issues.

[native-image --version] No way to tell version in use when JDK isn't jlinked nor compiled to binary
4 participants
@graalvmbot @fniephaus @jerboaa @zakkak