[GR-32340] Conditional resource configuration. #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff2c26a
to
0f2f511
Compare
ae2ac39
to
5721b9b
Compare
peter-hofer
approved these changes
Sep 14, 2021
| import java.util.List; | ||
| import java.util.function.Consumer; | ||
|
|
||
| public class ProxyRegistry extends ConditionalConfigurationRegistry implements Consumer<ConditionalElement<List<String>>> { |
There was a problem hiding this comment.
I think this should be ProxyRegistryImpl to be consistent with the other registries, and perhaps we should introduce a ProxyRegistry interface now instead of using Consumer.
| @@ -87,4 +87,9 @@ public int hashCode() { | |||
| public int compareTo(ConfigurationCondition o) { | |||
| return this.typeName.compareTo(o.typeName); | |||
| } | |||
There was a problem hiding this comment.
Maybe objectReachable() should really be named alwaysTrue() for easier comprehension of code that registers types, proxies, etc.
5721b9b
to
14c6ad3
Compare
zakkak
added a commit
to zakkak/quarkus
that referenced
this pull request
Sep 17, 2021
oracle/graal#3774 changed the signature of ignoreResources as follows: ``` - public void ignoreResources(String pattern) { + public void ignoreResources(ConfigurationCondition condition, String pattern) { ``` This results in Quarkus throwing a `NoSuchMethodError` exception at the code generated by NativeImageAutoFeatureStep This patch looks for the right method based on the GraalVM/Mandrel version. Closes: quarkusio#20226
zakkak
added a commit
to zakkak/quarkus
that referenced
this pull request
Sep 21, 2021
oracle/graal#3774 changed the signature of ignoreResources as follows: ``` - public void ignoreResources(String pattern) { + public void ignoreResources(ConfigurationCondition condition, String pattern) { ``` This results in Quarkus throwing a `NoSuchMethodError` exception at the code generated by NativeImageAutoFeatureStep This patch looks for the right method based on the GraalVM/Mandrel version. Closes: quarkusio#20226
zakkak
added a commit
to zakkak/quarkus
that referenced
this pull request
Sep 21, 2021
oracle/graal#3774 changed the signature of ignoreResources as follows: ``` - public void ignoreResources(String pattern) { + public void ignoreResources(ConfigurationCondition condition, String pattern) { ``` This results in Quarkus throwing a `NoSuchMethodError` exception at the code generated by NativeImageAutoFeatureStep This patch looks for the right method based on the GraalVM/Mandrel version. Closes: quarkusio#20226
geoand
pushed a commit
to geoand/quarkus
that referenced
this pull request
Sep 28, 2021
oracle/graal#3774 changed the signature of ignoreResources as follows: ``` - public void ignoreResources(String pattern) { + public void ignoreResources(ConfigurationCondition condition, String pattern) { ``` This results in Quarkus throwing a `NoSuchMethodError` exception at the code generated by NativeImageAutoFeatureStep This patch looks for the right method based on the GraalVM/Mandrel version. Closes: quarkusio#20226 (cherry picked from commit b5361d8)
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this pull request
Dec 1, 2021
oracle/graal#3774 changed the signature of ignoreResources as follows: ``` - public void ignoreResources(String pattern) { + public void ignoreResources(ConfigurationCondition condition, String pattern) { ``` This results in Quarkus throwing a `NoSuchMethodError` exception at the code generated by NativeImageAutoFeatureStep This patch looks for the right method based on the GraalVM/Mandrel version. Closes: quarkusio#20226 (cherry picked from commit b5361d8)
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this pull request
Dec 1, 2021
oracle/graal#3774 changed the signature of ignoreResources as follows: ``` - public void ignoreResources(String pattern) { + public void ignoreResources(ConfigurationCondition condition, String pattern) { ``` This results in Quarkus throwing a `NoSuchMethodError` exception at the code generated by NativeImageAutoFeatureStep This patch looks for the right method based on the GraalVM/Mandrel version. Closes: quarkusio#20226 (cherry picked from commit b5361d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit refactors the type resolver out and fixes an issue with reflection configuration.
The second commit introduces conditional configuration for resources.