Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5266: Call setUpDrawer( ) directly if binding already initialized #5276

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

theMr17
Copy link
Collaborator

@theMr17 theMr17 commented Dec 19, 2023

Explanation

Fixes #5266

This is happening because setUpDrawer() is not called when we go back to a particular fragment/activity. setUpDrawer() is now called from handleCreateView() which is called only when the fragment/activity is created. This is fixed by calling setUpDrawer() directly when calling via onRestart().

Before After
Before.mp4
After.mp4

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@theMr17 theMr17 requested a review from a team as a code owner December 19, 2023 08:23
@theMr17
Copy link
Collaborator Author

theMr17 commented Dec 19, 2023

@adhiamboperes PTAL

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theMr17, this LGTM.

@adhiamboperes adhiamboperes merged commit e81ba71 into oppia:develop Dec 19, 2023
37 checks passed
BenHenning added a commit that referenced this pull request Dec 23, 2023
BenHenning added a commit that referenced this pull request Dec 23, 2023
… binding already initialized" (#5285)

Fixes part of #5284

Reverts #5276 as part of preparing to revert #5191.

Note that this reintroduces #5266 but that should stay fixed once #5191
is reverted.
BenHenning added a commit that referenced this pull request Dec 23, 2023
… binding already initialized" (#5285)

Fixes part of #5284

Reverts #5276 as part of preparing to revert #5191.

Note that this reintroduces #5266 but that should stay fixed once #5191
is reverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Navigation drawer icon is not working after returning from topics.
2 participants