-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3140 Shifting Instrumentation tests in Unit test directory for AdministratorControlsFragmentTest #4107
Conversation
@yash10019coder PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Rohit1173 check for the static checks and also add a newline at the end of the file thanks
|
||
@Test | ||
fun testAdministratorControlsFragment_clickEditProfile_checkSendingTheCorrectIntent() { | ||
ActivityScenario.launch<AdministratorControlsActivity>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add resource inputs for these static object references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
) | ||
).use { | ||
testCoroutineDispatchers.runCurrent() | ||
Espresso.onView(ViewMatchers.withId(R.id.edit_profiles_text_view)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same goes here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Unassigning @yash10019coder since the review is done. |
Hi @Rohit1173, it looks like some changes were requested on this pull request by @yash10019coder. PTAL. Thanks! |
@Rohit1173 please fix failing ci checks and also I think that this PR is blocked by #4029 what do you think about this @rt4914 PTAL thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rohit1173 add resource imports and also fix failing test cases thanks
) | ||
).use { | ||
testCoroutineDispatchers.runCurrent() | ||
onView(ViewMatchers.withId(R.id.edit_profiles_text_view)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add resource imports for ViewMatchers and click performers in this and the following test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rohit1173 LGTM.
@rt4914 @anandwana001 PTAL |
Assigning @rt4914, @anandwana001 for code owner reviews. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rohit1173 PTAL thanks.
...edTest/java/org/oppia/android/app/administratorcontrols/AdministratorControlsFragmentTest.kt
Outdated
Show resolved
Hide resolved
...edTest/java/org/oppia/android/app/administratorcontrols/AdministratorControlsFragmentTest.kt
Outdated
Show resolved
Hide resolved
...edTest/java/org/oppia/android/app/administratorcontrols/AdministratorControlsFragmentTest.kt
Outdated
Show resolved
Hide resolved
...edTest/java/org/oppia/android/app/administratorcontrols/AdministratorControlsFragmentTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a nit suggestion.
import javax.inject.Inject | ||
import javax.inject.Singleton | ||
|
||
@RunWith(AndroidJUnit4::class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment above this:
/** Tests for [AdministratorControlsFragment]. */
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Unassigning @anandwana001 since they have already approved the PR. |
@rt4914 changes done, PTAL.Thanks |
Unassigning @Rohit1173 since a re-review was requested. @Rohit1173, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Explanation
Fix #3140: Shifting tests which were instrumentation tests but written in the Unit test directory in the AdministratorControlsFragmentTest
Shifted tests Screenshot (Device(Emulator): Pixel-3A , API-28)
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: