-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3971: [RTL] Add style for all the TextViews. #3989
Conversation
Thanks @rt4914 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @veena14cs. Took a pass on the latest changes--PTAL.
app/src/main/res/layout-sw600dp-land/profile_chooser_add_view.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @veena14cs. Just a few comments left. Some of them might be correct as-is per your earlier comments, but I just wanted to double check.
@BenHenning I have made changes and addressed your comments PTAL. |
Unassigning @veena14cs since a re-review was requested. @veena14cs, please make sure you have addressed all review comments. Thanks! |
@BenHenning and @veena14cs I have answered/resolved to all the comment threads that were started by me. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @veena14cs! I have nothing else to add. I think this is a really nice change toward centrally managing RTL properties, and sets us up for more cleanly organizing centralized styles & enforcing their presence in future work.
Thanks @rt4914! |
Merging since there are no more open conversation threads & everything is approved. |
Explanation
This PR fixes #3971 . This PR ensures that all the Textviews have style attribute set, to generally manage the text alignment for RTL/LTR where the texts are aligned to right or left and the texts that are center-aligned.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: