Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3985: [RTL] Developer options screens #3986

Merged
merged 97 commits into from
Nov 9, 2021

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Nov 8, 2021

Explanation

This PR fixes #3985 . This PR fixes alignment issues on all of the screens inside Developer options.

Screenshot LTR and RTL

Screenshot_1636377750...Screenshot_1636377781

Screenshot_1636377755...Screenshot_1636377775

Screenshot_1636377732.....Screenshot_1636377662

Screenshot_1636377724...Screenshot_1636377671

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@veena14cs veena14cs added this to the RTL Support milestone Nov 8, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 removed their assignment Nov 8, 2021
@veena14cs veena14cs merged commit b86cfa1 into oppia:develop Nov 9, 2021
@veena14cs veena14cs deleted the developer-option branch November 9, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developer options section need support for RTL
3 participants