Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3567: Merge profile_reset_pin_activity.xml into single xml file #3942

Merged
merged 6 commits into from
Oct 18, 2021
Merged

Fix #3567: Merge profile_reset_pin_activity.xml into single xml file #3942

merged 6 commits into from
Oct 18, 2021

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Oct 16, 2021 •
edited
Loading

Fix #3567

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).
OLD Screenshots Mobile NEW Screenshots Mobile
Screenshot_20210804_152357 Screenshot_20210804_152357
Screenshot_20210804_152412 Screenshot_20210804_152412
OLD Screenshots TABLET NEW Screenshots TABLET
Screenshot_20210804_152456 Screenshot_20210804_152456
Screenshot_20210804_152510 Screenshot_20210804_152510

@MohitGupta121 MohitGupta121 mentioned this pull request Oct 16, 2021
Closed
@MohitGupta121
Copy link
Member Author

@rt4914 Bro can you please review my this pull request.
As in my old PR I said the Tab screenshots is from the online tablet emulator apkonline.net . Because my PC not able to run emulator with Android Studio.

rt4914
rt4914 approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 72d44eb into oppia:develop Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge profile_reset_pin_activity.xml into single xml file
2 participants
@MohitGupta121 @rt4914