-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3276: Create Build.bazel file for onboarding #3877
Fix #3276: Create Build.bazel file for onboarding #3877
Conversation
@BenHenning I am getting this error can you please help me out with this. Even after adding dependencies to the app BUILD.bazel file, I am not able to build below are the log files. |
Thanks @rishidyno! Apologies, but I'll need to take a look at this tomorrow. |
domain/src/main/java/org/oppia/android/domain/onboarding/BUILD.bazel
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/onboarding/BUILD.bazel
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/onboarding/BUILD.bazel
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/onboarding/BUILD.bazel
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/onboarding/testing/BUILD.bazel
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/onboarding/testing/BUILD.bazel
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rishidyno. Had some follow-up comments. PTAL.
@BenHenning I am getting this error can you please help me out with this. Even after adding dependencies to the app BUILD.bazel file, I am not able to build below are the log files.
This issue is coming because OnboardingSlideFinalViewModel needs AppStartupStateController, but its dependency can't be resolved. You only added AppStartupStateController to "app" library, but OnboardingSlideFinalViewModel is defined as part of "view_models" (which means view_models' deps need to be updated to point to AppStartupStateController's library).
domain/src/main/java/org/oppia/android/domain/onboarding/testing/BUILD.bazel
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/onboarding/testing/BUILD.bazel
Outdated
Show resolved
Hide resolved
Actually, I tried doing that but there is no build.bazel file for app/onboarding. For this I will have to create bazel file for app/onboarding as well. should I do that? |
Unassigning @rishidyno since a re-review was requested. @rishidyno, please make sure you have addressed all review comments. Thanks! |
Please, let me know If I have left any changes suggested by you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rishidyno. Had some more follow-up comments--PTAL.
Thanks @rishidyno. Had some follow-up comments. PTAL.
@BenHenning I am getting this error can you please help me out with this. Even after adding dependencies to the app BUILD.bazel file, I am not able to build below are the log files. screenshot
screenshotThis issue is coming because OnboardingSlideFinalViewModel needs AppStartupStateController, but its dependency can't be resolved. You only added AppStartupStateController to "app" library, but OnboardingSlideFinalViewModel is defined as part of "view_models" (which means view_models' deps need to be updated to point to AppStartupStateController's library).
Actually, I tried doing that but there is no build.bazel file for app/onboarding. For this I will have to create bazel file for app/onboarding as well. should I do that?
Please, let me know If I have left any changes suggested by you.
You'll need to change
Line 636 in 2c6aebd
deps = [ |
domain/src/main/java/org/oppia/android/domain/onboarding/BUILD.bazel
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/onboarding/testing/BUILD.bazel
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/onboarding/testing/BUILD.bazel
Outdated
Show resolved
Hide resolved
@BenHenning Made all required changes PTAL. |
Unassigning @rishidyno since a re-review was requested. @rishidyno, please make sure you have addressed all review comments. Thanks! |
…bazel-file-for-onboarding
@BenHenning I am really sorry for being away. |
FYI I'm listed as a codeowner for this PR & I'll be unavailable to perform code reviews over the next 2 weeks--thanks for your patience. |
@rishidyno the Bazel lint check output isn't very helpful, but you're right that there are syntax errors. Buildifier is a tool that can automatically fix most Bazel build file errors: https://github.com/bazelbuild/buildtools/blob/master/buildifier/README.md. Regarding the actual failures, the top error I see is:
This usually means a syntax or logical build graph issue in the BUILD file the test is defined. Since this is an unmigrated test, that means domain/BUILD.bazel. However, since you didn't change that file then it means one of the build files it depends on has the issue. I suggest going through the build files one-by-one and comment out your changes until you find the culprit line. That should help you then figure out what went wrong. |
Hi @rishidyno, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
@BenHenning all tests have passed PTAL . |
Unassigning @rishidyno since a re-review was requested. @rishidyno, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rishidyno! I think you might have missed one of my past comments--PTAL (in general, please make sure to reply to all reviewer comments before sending the PR back for review just to make sure everything's been acknowledge or addressed). You can quickly find these by going to the 'Conversations' drop down on the 'Files changed' tab.
Beyond that, the PR looks really good. I think just the one change I'm requesting is needed before this PR can be merged.
domain/src/main/java/org/oppia/android/domain/onboarding/testing/BUILD.bazel
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/onboarding/testing/BUILD.bazel
Outdated
Show resolved
Hide resolved
to `retriever_prod_module`
…bazel-file-for-onboarding
@BenHenning All tests have passed PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rishidyno! This LGTM.
Fix #3276
Explanation
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: