Fix #3236: Hi-Fi Add Profile Tablet

[viktoriias]

Explanation

Fixes #3236: Hi-Fi Add Profile Tablet:

• Remove layout-land file
• Introduce dimensions resources

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

[viktoriias]

Portrait Phone

Before	After

[viktoriias]

Landscape Phone

Before	After

[viktoriias]

@rt4914 Please review.

[rt4914]

@viktoriias The issue is related to two things:

1. Creating a single xml file instead of multiple files.
2. Creating Highfi for Tablet mocks too.

Currently this PR is doing 1st task only.

Also the approach mentioned in this PR has been to keep the margins fixed and the content width to be variable. But instead in general we are shifting towards keeping the content width fixed and margins to be variable. You can notice this in mocks too. For example: If you open mobile-portrait and mobile-landscape mocks you will notice that maximum width of items is 304dp which means that irrespective of screen width we are keeping it 304dp width. And for tablet-portrait and tablet-landscape this is 360dp width.

So basically you just need to creating a container which holds all views in it correctly and based on which device/configuration it is you need to control the width of the container to be either 304dp or 360dp.

[viktoriias]

@viktoriias The issue is related to two things:

1. Creating a single xml file instead of multiple files.
2. Creating Highfi for Tablet mocks too.

Currently this PR is doing 1st task only.

Also the approach mentioned in this PR has been to keep the margins fixed and the content width to be variable. But instead in general we are shifting towards keeping the content width fixed and margins to be variable. You can notice this in mocks too. For example: If you open mobile-portrait and mobile-landscape mocks you will notice that maximum width of items is 304dp which means that irrespective of screen width we are keeping it 304dp width. And for tablet-portrait and tablet-landscape this is 360dp width.

So basically you just need to creating a container which holds all views in it correctly and based on which device/configuration it is you need to control the width of the container to be either 304dp or 360dp.

I created a separate PR: #3724 - PTAL

[oppiabot]

Hi @viktoriias, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 3 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!