Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3600: Add complete UI for tablet devices for copyright licenses lists and texts #3680

Merged
merged 108 commits into from
Aug 19, 2021
Merged

Fix #3600: Add complete UI for tablet devices for copyright licenses lists and texts #3680

merged 108 commits into from
Aug 19, 2021

Conversation

prayutsu
Copy link
Contributor

@prayutsu prayutsu commented Aug 14, 2021 •
edited
Loading

Explanation

Fixes #3600:
Added split mode support on tablet devices for LicenseListFragment and LicenseTextViewerFragment.

Portrait Landscape
Screenshot_1629013550 Screenshot_1629013557
Screenshot_1629013803 Screenshot_1629013792
Screenshot_1629013904 Screenshot_1629013897
Screenshot_1629013880 Screenshot_1629013886
Screenshot_2021-08-15-13-33-21-234_org oppia android Screenshot_2021-08-15-13-29-51-448_org oppia android
Screenshot_2021-08-15-13-29-54-437_org oppia android Screenshot_2021-08-15-13-36-23-887_org oppia android

Test cases-
Screenshot from 2021-08-16 21-43-27
(3 test cases failing in espresso that are only meant for mobile)
Screenshot from 2021-08-16 21-49-05

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@prayutsu
Create ThirdPartyActivity
1c7f2a1
@prayutsu
Fix lints
41d01d2
@prayutsu
Fix actionbar issue
ced7633
@prayutsu
Add tests
c76e1cb
@prayutsu
Add KDocs
b4b7869
@prayutsu
Add LicenseListActivity to Manifest
6b7c417
@prayutsu
Fix LicenseListFragment
f2893aa
@prayutsu
Merge branch 'develop' of github.com:oppia/oppia-android into display…
cdd569c 
…-dependencies-list
@prayutsu
Add test cases
8869156
@prayutsu
Add LicenseTextViewerFragment
46d71f9
@prayutsu
Pass index to LicenseListFragment
2414c77
@prayutsu
Fix all the bugs
91dbd1d
@prayutsu
Fix lints
5dc5e8d
@prayutsu
Add tests files for all activities and fragments
ef6dfac
@prayutsu
Fix lints
05883aa
@prayutsu
Add viewModels to BUILD.bazel
b2b4134
@prayutsu
Correct path of files in exemptions file
b420bce
@prayutsu
Add suggested changes
f58b2d5
@prayutsu
Add suggested changes
6da89ef
@prayutsu
Remove unused imports
9243bae
@prayutsu
Correct styles in xml
e2a473f
@prayutsu
Optimize layouts
5c6d0df
@prayutsu
fix lints
c4e0ca9
@prayutsu
Correct layout width
696dfae
@prayutsu
Add test cases for all files
86a3fdd
@prayutsu
Add an extra test case
5724f53
@prayutsu
Add more test cases
92bd873
@prayutsu
revert changes in ktlint_lint_check.sh
e9cc0b7
@prayutsu
Add suggested changes
230689b
@prayutsu
Add marquee effect
f580b3b
rt4914
rt4914 suggested changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prayutsu Overall good. Can you add one test case for this case too ?

app/src/main/java/org/oppia/android/app/help/HelpActivity.kt Show resolved Hide resolved
app/src/main/java/org/oppia/android/app/help/HelpActivityPresenter.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/android/app/help/thirdparty/LicenseTextViewerFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/android/app/help/thirdparty/ThirdPartyDependencyListFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/android/app/help/thirdparty/ThirdPartyDependencyListFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/android/app/help/thirdparty/ThirdPartyDependencyListFragment.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/help/HelpFragmentTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/help/HelpFragmentTest.kt Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned prayutsu and unassigned rt4914 Aug 17, 2021
Base automatically changed from add-tablet-ui-for-faq-and-third-party-dependency-lists to develop August 18, 2021 08:00
@prayutsu prayutsu assigned rt4914 and unassigned prayutsu Aug 18, 2021
@prayutsu
Copy link
Contributor Author

Screenshots of new test case passing-
Screenshot from 2021-08-18 14-26-28
Screenshot from 2021-08-18 14-16-14

rt4914
rt4914 suggested changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prayutsu One change suggested in open comments related to content-description

@rt4914 rt4914 assigned prayutsu and unassigned rt4914 Aug 18, 2021
@prayutsu prayutsu assigned rt4914 and unassigned prayutsu Aug 19, 2021
@prayutsu
Copy link
Contributor Author

PTAL @rt4914

rt4914
rt4914 approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@rt4914 rt4914 merged commit d219920 into develop Aug 19, 2021
@rt4914 rt4914 deleted the hifi-tablet-third-party branch August 19, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@BenHenning BenHenning BenHenning approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hi-fi (Tablet) for displaying third-party dependencies and their license links
3 participants
@prayutsu @rt4914 @BenHenning