-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3490 Add resume lesson activity [Blocked on #3488] #3670
Conversation
…nto move-hint-handler-to-domain
…o move-hint-handler-to-domain
…-in-domain-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MaskedCarrot. LGTM, but waiting on approving until it's based on develop with passing CI. Please assign back at that point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving my last suggestion got fixed. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MaskedCarrot. LGTM!
Merging since everyone has approved, CI is passing, branch is up-to-date & looks good, and no conversation threads are open anymore. |
Explanation
Fixes #3490
Checklist
Final result
Mobile
Tablet
Espresso test
ResumeLessonActivityTest
ResumeLessonFragmentTest