Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3665: [RTL] High-fi Remove textdirection attribute from all the TextViews and fix text alignment #3666

Merged
merged 47 commits into from
Aug 13, 2021
Merged

Fix #3665: [RTL] High-fi Remove textdirection attribute from all the TextViews and fix text alignment #3666

merged 47 commits into from
Aug 13, 2021

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Aug 10, 2021 •
edited
Loading

Explanation

This PR fixes #3665. This PR removes textdirection property from Textviews used in the project and fixes text alignment for RTL.

Screenshot LTR and RTL

Mobile
Screenshot_1628756888.... Screenshot_1628756836

Screenshot_1628756898......Screenshot_1628756844

Screenshot_1628804107....Screenshot_1628804064

Screenshot_1628804129.....Screenshot_1628804050

Tablet
Screenshot_1628799081.....Screenshot_1628797646

Screenshot_1628799088.....Screenshot_1628797638

Screenshot_1628799046....Screenshot_1628798965

Screenshot_1628799038.......Screenshot_1628798972

Screenshot_1628801987.....Screenshot_1628801720

Screenshot_1628801975....Screenshot_1628801736

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@veena14cs
Update selection_interaction_item.xml
76c542f
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
03dbae2
@veena14cs
Update selection_interaction_item.xml
1eaa794
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
c122fa9
@veena14cs
Update return_to_topic_button_item.xml
fa01718
@veena14cs
Update return_to_topic_button_item.xml
1ddff1b
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
75f3191
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
0153870
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
b655173
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
251b720
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
21402ab
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
77ed59c
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
dd9379c
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
eceec2f
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
b136ffc
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
d01b5e6
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
1494b90
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
231a322
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
2d744e1
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
77d9961
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
26bd197
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
754b2b1
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
839e45a
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
005553c
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
8fa1abd
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
3b6cbda
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
d089c26
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
4e49e45
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
ed7044b
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
17a0935
@veena14cs veena14cs requested a review from rt4914 as a code owner August 10, 2021 21:55
@veena14cs veena14cs added the Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. label Aug 10, 2021
rt4914
rt4914 suggested changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veena14cs Please add RTL screenshots for all files which have been changed.

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Aug 12, 2021
@veena14cs veena14cs changed the title Fix #3665: [RTL] High-fi Remove textdirection attribute from all the TextViews Fix #3665: [RTL] High-fi Remove textdirection attribute from all the TextViews and fix text alignment Aug 12, 2021
@veena14cs veena14cs requested a review from rt4914 August 12, 2021 21:41
@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Aug 12, 2021
@veena14cs
Copy link
Contributor Author

@veena14cs Please add RTL screenshots for all files which have been changed.

@rt4914 Added screenshots. PTAL

rt4914
rt4914 approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one nit change.

app/src/main/res/layout-land/topic_info_fragment.xml Outdated
android:textSize="24sp"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintHorizontal_bias="0.0"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: space before />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically use reformatting shortcut in all files before merging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914. Done reformatting here and elsewhere.

@rt4914 rt4914 removed their assignment Aug 13, 2021
@oppiabot oppiabot bot added the PR: LGTM label Aug 13, 2021
@veena14cs veena14cs merged commit a43e743 into oppia:develop Aug 13, 2021
@veena14cs veena14cs deleted the fix-textdirection branch August 13, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@veena14cs veena14cs

Labels
PR: LGTM Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RTL] High-fi Remove textdirection attribute from all the TextViews and fix textalignment issues
2 participants
@veena14cs @rt4914