Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3312, #3396 and #3397: Implement Show All Hints and Solution feature. #3613

Closed
wants to merge 9 commits into from

Conversation

yashraj-01
Copy link
Contributor

@yashraj-01 yashraj-01 commented Jul 30, 2021

Explanation

Fixes #3312. Took out HintHandler from StatePlayerRecyclerViewAssembler and created a separate class for it.
Fixes #3396. Introduced debug implementation of HintHandler.
Fixes #3397. Implemented logic to show all hints and solution feature.

Screenshots

  • After enabling the feature
screen_record.mp4
  • Espresso Tests passing for DeveloperOptionsFragmentTest
    Screenshot from 2021-07-31 12-39-19

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001
Copy link
Contributor

@Sparsh1212 Could you help us here in getting this PR review asap?

@Sparsh1212 Sparsh1212 added the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label Jul 30, 2021
@yashraj-01 yashraj-01 removed the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label Aug 5, 2021
@yashraj-01 yashraj-01 marked this pull request as ready for review August 5, 2021 11:54
@yashraj-01 yashraj-01 marked this pull request as draft August 6, 2021 13:02
@oppiabot
Copy link

oppiabot bot commented Aug 14, 2021

Hi @yashraj-01, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 3 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Aug 14, 2021
@yashraj-01 yashraj-01 removed their assignment Aug 14, 2021
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Aug 14, 2021
@yashraj-01
Copy link
Contributor Author

Closing this PR as the approach is completely changed now.

@yashraj-01 yashraj-01 closed this Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants