Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3310: Introduce Prod and Debug Implementation of NetworkConnectionUtil #3512

Merged
merged 61 commits into from
Aug 17, 2021
Merged

Fix #3310: Introduce Prod and Debug Implementation of NetworkConnectionUtil #3512

merged 61 commits into from
Aug 17, 2021

Conversation

yashraj-01
Copy link
Contributor

@yashraj-01 yashraj-01 commented Jul 21, 2021 •
edited
Loading

Explanation

Fixes #3310. Introduced Prod and Debug implementations of NetworkConnectionUtil.

Screenshots

  • Robolectric tests passing for ProdNetworkConnectionUtilTest
    Screenshot from 2021-07-22 22-37-11

  • Robolectric tests passing for DebugNetworkConnectionUtilTest
    Screenshot from 2021-07-22 22-37-28

  • Robolectric tests passing for NetworkConnectionTestUtilTest
    Screenshot from 2021-07-28 13-39-08

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Sarthak2601
Sarthak2601 suggested changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @yashraj-01. Suggested nits majorly.

utility/src/main/java/org/oppia/android/util/networking/NetworkConnectionUtil.kt Outdated Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/networking/NetworkConnectionUtilDebugImpl.kt Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/networking/NetworkConnectionUtilDebugImpl.kt Outdated Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/networking/NetworkConnectionUtilDebugImpl.kt Outdated Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/networking/NetworkConnectionUtilDebugImpl.kt Outdated Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/networking/NetworkConnectionUtilProdImpl.kt Outdated Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/networking/NetworkConnectionUtilProdImpl.kt Show resolved Hide resolved
utility/src/test/java/org/oppia/android/util/networking/NetworkConnectionUtilDebugImplTest.kt Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Jul 22, 2021

Unassigning @Sarthak2601 since the review is done.

@oppiabot
Copy link

oppiabot bot commented Jul 22, 2021

Hi @yashraj-01, it looks like some changes were requested on this pull request by @Sarthak2601. PTAL. Thanks!

@BenHenning
Copy link
Sponsor Member

BenHenning commented Jul 22, 2021 •
edited
Loading

Given my current load of PRs, I'll need to defer this until after @Sarthak2601 has approved. Could you please reassign this to me at that point @yashraj-01?

@BenHenning BenHenning removed their assignment Jul 22, 2021
anandwana001
anandwana001 suggested changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a nit suggestion for now. Please check the failing CI checks.

utility/src/main/java/org/oppia/android/util/networking/NetworkConnectionUtilProdModule.kt Outdated Show resolved Hide resolved
@anandwana001 anandwana001 removed their assignment Jul 22, 2021
@BenHenning BenHenning assigned yashraj-01 and unassigned BenHenning Aug 10, 2021
@yashraj-01 yashraj-01 assigned BenHenning and unassigned yashraj-01 Aug 11, 2021
BenHenning
BenHenning requested changes Aug 13, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yashraj-01.Overall, I think this looks really good. Just had a few follow-up comments, otherwise the PR LGTM.

utility/src/main/java/org/oppia/android/util/networking/NetworkConnectionDebugUtil.kt Outdated Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/networking/ConnectionStatus.kt Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/networking/NetworkConnectionDebugUtil.kt Outdated Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/networking/NetworkConnectionUtilDebugImpl.kt Outdated Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/networking/BUILD.bazel Outdated Show resolved Hide resolved
@BenHenning BenHenning assigned yashraj-01 and unassigned BenHenning Aug 13, 2021
@yashraj-01 yashraj-01 assigned BenHenning and unassigned yashraj-01 Aug 13, 2021
BenHenning
BenHenning approved these changes Aug 13, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yashraj-01. LGTM!

@BenHenning
Copy link
Sponsor Member

I'm inclined to merge this as-is since the previous test pass was fully green, but let's wait until all the tests complete.

@oppiabot
Copy link

oppiabot bot commented Aug 14, 2021

Unassigning @BenHenning since they have already approved the PR.

@yashraj-01 yashraj-01 changed the title Fix #3310: Introduce Prod and Debug Implementation of NetworkConnectionUtil Fix #3310: Introduce Prod and Debug Implementation of NetworkConnectionUtil [Merge Blocked on CI fix: #3682] Aug 15, 2021
@yashraj-01 yashraj-01 changed the title Fix #3310: Introduce Prod and Debug Implementation of NetworkConnectionUtil [Merge Blocked on CI fix: #3682] Fix #3310: Introduce Prod and Debug Implementation of NetworkConnectionUtil Aug 16, 2021
@Sarthak2601 Sarthak2601 merged commit a086835 into develop Aug 17, 2021
@Sarthak2601 Sarthak2601 deleted the prod-and-debug-networkconnectionutil branch August 17, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sparsh1212 Sparsh1212 Sparsh1212 left review comments

@rt4914 rt4914 rt4914 approved these changes

@vinitamurthi vinitamurthi vinitamurthi approved these changes

@BenHenning BenHenning BenHenning approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

@Sarthak2601 Sarthak2601 Sarthak2601 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Prod and Dev Implementation of NetworkConnectionUtil
7 participants
@yashraj-01 @BenHenning @rt4914 @vinitamurthi @anandwana001 @Sarthak2601 @Sparsh1212