Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2635: [A11y]Topic Lessons #3476

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Fix #2635: [A11y]Topic Lessons #3476

merged 2 commits into from
Jul 14, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jul 13, 2021 •
edited
Loading

Explanation

Fix #2635: [A11y]Topic Lessons

This PR makes sure that all content inside Topic Lessons is correct accessible by learners.

Output

a11y_topic_lessons_collapsed.mp4
a11y_topic_lessons_expanded.mp4

Screenshot 2021-07-14 at 1 03 34 AM

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 requested a review from anandwana001 July 13, 2021 19:20
anandwana001
anandwana001 approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandwana001 anandwana001 merged commit 3d055ef into develop Jul 14, 2021
@anandwana001 anandwana001 deleted the a11y-topic-lessons branch July 14, 2021 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 anandwana001 approved these changes

Assignees

@anandwana001 anandwana001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[A11y] Topic Lessons [Blocked]
2 participants
@rt4914 @anandwana001