Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3131: Add Profile toggle radio buttons by clicking on the complete item #3191

Merged
merged 7 commits into from
May 19, 2021
Merged

Fix #3131: Add Profile toggle radio buttons by clicking on the complete item #3191

merged 7 commits into from
May 19, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented May 13, 2021

Explanation

Fixes #3131

This PR makes the entire Switch + 2 Texts clickable in add profile. Also the changes have been made to make it correctly accessible too which is shown in below screenshot:

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Rajat Talesra added 2 commits May 13, 2021 16:48
@rt4914 rt4914 requested a review from FareesHussain May 13, 2021 11:24
@rt4914 rt4914 requested a review from Arjupta May 13, 2021 11:25
FareesHussain
FareesHussain suggested changes May 13, 2021
View reviewed changes
Copy link
Contributor

@FareesHussain FareesHussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 Left a comment, PTAL

app/src/main/res/layout/add_profile_activity.xml Outdated Show resolved Hide resolved
@FareesHussain FareesHussain assigned rt4914 and unassigned FareesHussain and rt4914 May 13, 2021
FareesHussain
FareesHussain approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@FareesHussain FareesHussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 requested a review from anandwana001 May 13, 2021 11:57
Arjupta
Arjupta reviewed May 13, 2021
View reviewed changes
Copy link
Contributor

@Arjupta Arjupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 the text output that we see here -
"Allow Download Access, Enable the ... Administrator Pin, not checked, OFF, Switch"

Is this bevaiour normal to repeat the mention of switch-state? ( ie not checked and OFF)

@rt4914
Copy link
Contributor Author

rt4914 commented May 13, 2021

@rt4914 the text output that we see here -
"Allow Download Access, Enable the ... Administrator Pin, not checked, OFF, Switch"

Is this bevaiour normal to repeat the mention of switch-state? ( ie not checked and OFF)

@Arjupta yes. I have checked switches across multiple apps and I have found three types of behaviour: checked/not-checked, ON/OFF and combination of both checked, ON / not-checked, OFF.
So finally we decided not to alter anything and keep it whatever it is by default.

Arjupta
Arjupta approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@Arjupta Arjupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arjupta Arjupta removed their assignment May 13, 2021
anandwana001
anandwana001 suggested changes May 17, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914

Left few thoughts/questions.

app/src/main/java/org/oppia/android/app/profile/AddProfileActivityPresenter.kt Show resolved Hide resolved
app/src/main/res/layout-sw600dp-land/add_profile_activity.xml Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/profile/AddProfileActivityTest.kt Show resolved Hide resolved
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 May 17, 2021
@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 May 17, 2021
anandwana001
anandwana001 suggested changes May 17, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Could you add espresso result screenshot?

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 May 17, 2021
@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 May 18, 2021
@rt4914
Copy link
Contributor Author

rt4914 commented May 18, 2021

Sounds good.

Could you add espresso result screenshot?

Screenshot 2021-05-18 at 5 38 07 PM

anandwana001
anandwana001 approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @rt4914

@anandwana001 anandwana001 merged commit 83fae2c into develop May 19, 2021
@anandwana001 anandwana001 deleted the add-profile-complete-toggle-click branch May 19, 2021 02:57
This was referenced Jul 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FareesHussain FareesHussain FareesHussain approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

@Arjupta Arjupta Arjupta approved these changes

Assignees

@anandwana001 anandwana001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Profile toggle radio buttons by clicking on the complete item
4 participants
@rt4914 @anandwana001 @FareesHussain @Arjupta