Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #40 & #42: Outer margins changed for SelectionInteraction #3183

Merged
merged 3 commits into from
May 19, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merged with develop
  • Loading branch information
Rajat Talesra committed May 13, 2021
commit e668cf344d8342663a23307fa7e342bf469824f7
4 changes: 0 additions & 4 deletions app/src/main/res/values-land/dimens.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@
<dimen name="state_fragment_non_split_view_margin_end">120dp</dimen>
<dimen name="state_fragment_non_split_view_margin_start">120dp</dimen>
<dimen name="numeric_input_interaction_item_conversation_view_margin_start">80dp</dimen>
<dimen name="previous_responses_item_exploration_view_margin_end">80dp</dimen>
<dimen name="previous_responses_item_exploration_view_margin_start">80dp</dimen>
<dimen name="previous_responses_item_question_view_margin_end">80dp</dimen>
<dimen name="previous_responses_item_question_view_margin_start">80dp</dimen>
<dimen name="drag_drop_item_exploration_split_view_margin_top">40dp</dimen>
<dimen name="drag_drop_item_question_split_view_margin_top">40dp</dimen>
<dimen name="submitted_answer_exploration_split_view_margin_start">40dp</dimen>
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/res/values-sw600dp-land/dimens.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@
<dimen name="profile_chooser_profile_view_parent_margin_end_profile_not_added">298dp</dimen>
<dimen name="numeric_input_interaction_item_conversation_view_margin_start">208dp</dimen>
<dimen name="drag_drop_item_exploration_view_margin_start">208dp</dimen>
<dimen name="previous_responses_item_exploration_view_margin_end">208dp</dimen>
<dimen name="previous_responses_item_exploration_view_margin_start">208dp</dimen>
<dimen name="previous_responses_item_question_view_margin_end">208dp</dimen>
<dimen name="previous_responses_item_question_view_margin_start">208dp</dimen>
<dimen name="submitted_answer_exploration_view_margin_start">208dp</dimen>
<dimen name="text_input_interaction_item_conversation_view_margin_start">208dp</dimen>

Expand Down
4 changes: 0 additions & 4 deletions app/src/main/res/values-sw600dp-port/dimens.xml
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,6 @@

<dimen name="drag_drop_item_exploration_view_margin_start">144dp</dimen>
<dimen name="numeric_input_interaction_item_conversation_view_margin_start">144dp</dimen>
<dimen name="previous_responses_item_exploration_view_margin_end">144dp</dimen>
<dimen name="previous_responses_item_exploration_view_margin_start">144dp</dimen>
<dimen name="previous_responses_item_question_view_margin_end">144dp</dimen>
<dimen name="previous_responses_item_question_view_margin_start">144dp</dimen>
<dimen name="submitted_answer_item_exploration_view_margin_start">144dp</dimen>
<dimen name="text_input_interaction_item_conversation_view_margin_start">144dp</dimen>
<dimen name="profile_chooser_fragment_margin_top_profile_not_added">124dp</dimen>
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.