[RunAllTests] Attempt to fix GitHub actions cache flake #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
changed the title
BenHenning
changed the title
|
Reopening to kick-off full Bazel test run to see if the issue can repro (chances are we'll need to wait for a few runs after merging this PR to be sure it actually fixed the problem). |
|
Aha! This has nothing to do with GitHub. It's the same issue as #2691 (comment) just manifesting itself differently. Closing this since it's not actually relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Flakes like this are now being observed after caching was introduced in #3035:
The variable format change probably won't make a difference, it's just a "correctness" thing per what I saw others doing. I'm hoping that using a bash shell will help, but I'm not confident. It's weird because it seems like echo is outputting the wrong data.
This fix is just experimental--I haven't actually found anyone hitting this problem yet.