Enable D8 dex merging #3014
Merged
Enable D8 dex merging #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables D8 dex merging in Bazel builds since it seems the compatibility version doesn't seem to work with the latest SDK tools (31.0.1).
|
Thanks! |
BenHenning
added a commit
that referenced
this pull request
Mar 29, 2021
This reverts commit f81d8a3.
BenHenning
added a commit
that referenced
this pull request
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This enables D8 dex merging in Bazel builds since it seems the compatibility version doesn't seem to work with the latest SDK tools (31.0.1).
bazelbuild/bazel#10287 (comment) has a bit more context on why these particular flags are necessary.
Note that the binary building successfully on CI should be a sufficient check to ensure nothing has regressed. I've verified locally that the build runs.