Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #136: Topic overview low fi part 2 - Topic Download/Delete [ON HOLD] #236

Closed

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Oct 15, 2019

Explanation

This PR is based on PR #233 and implements Topic Download and Delete functionality.

Mock: https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/b98da363-bac6-4f7d-b1d2-ee0f9aa048c4/Topic-w-o-Play-8

For testing purpose make following change in code:

  1. Launcher activity should be TopicActivity
  2. Inside TopicActivityPresenter change TopicFragment to TopicOverviewFragment

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is assigned to an appropriate reviewer.

@rt4914
Copy link
Contributor Author

rt4914 commented Oct 15, 2019

@veena14cs @nikitamarysolomanpvt This PR does not contain any test-cases but is ready in terms of functionality. You can have the first review.

Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Oct 15, 2019
@rt4914 rt4914 removed their assignment Oct 15, 2019
@rt4914
Copy link
Contributor Author

rt4914 commented Oct 18, 2019

@BenHenning This PR is ready for your review.

@BenHenning
Copy link
Sponsor Member

Thanks @rt4914. Apologies for the noise, but we're actually deprioritizing topic download/deletion flows for the prototype. Since we may not finish the infrastructure work for this (#169) in the prototype time frame, I'd rather not have the UI in place. Let's put this on hold for now (and keep the PR open) with the intention of completing it post prototype.

Let me know if you'd like to discuss this further.

@BenHenning BenHenning changed the title Fix part of #136: Topic overview low fi part 2 - Topic Download/Delete Fix part of #136: Topic overview low fi part 2 - Topic Download/Delete [DO NOT MERGE--on hold] Oct 21, 2019
@BenHenning BenHenning changed the title Fix part of #136: Topic overview low fi part 2 - Topic Download/Delete [DO NOT MERGE--on hold] Fix part of #136: Topic overview low fi part 2 - Topic Download/Delete [ON HOLD] Oct 21, 2019
@rt4914
Copy link
Contributor Author

rt4914 commented Oct 21, 2019

Thanks @rt4914. Apologies for the noise, but we're actually deprioritizing topic download/deletion flows for the prototype. Since we may not finish the infrastructure work for this (#169) in the prototype time frame, I'd rather not have the UI in place. Let's put this on hold for now (and keep the PR open) with the intention of completing it post prototype.

Let me know if you'd like to discuss this further.

Okay no issues. This makes sense.

@rt4914 rt4914 removed their assignment Oct 21, 2019
@rt4914 rt4914 closed this Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants