Fix #2237: Remove orientation attribute from ConstraintLayout and FrameLayout.

[fsharpasharp]

Explanation

Fixes #2237 by removing the orientation attribute from ConstraintLayout and FrameLayout since the attribute is not neccesary for those layouts.

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

[BenHenning]

Thanks @fsharpasharp! This looks great! When looking at the branch, I noticed a few more places that incorrectly set the orientation:

• cellular_data_dialog.xml (CheckBox)
• faq_list_fragment.xml (NestedScrollView)
• profile_picture_edit_dialog.xml (2 TextViews)
• topic_activity.xml (FrameLayout)

(I only scanned layout/ and none of the variants). I know these aren't related to ConstraintLayout or FrameLayout (minus one case), but it's preferable just to get these all cleaned up while here. In general, only Guideline, RecyclerView, and LinearLayout should have orientation defined. Can you please:

1. Fix the above occurrences + their layout-land, layout-sw600dp, layout-sw600dp-port, and layout-sw600dp-land variants
2. Double check all layouts that orientation is only defined in the expected places (noting that I only personally checked layout/ in my findings above)

[fsharpasharp]

Thanks @fsharpasharp! This looks great! When looking at the branch, I noticed a few more places that incorrectly set the orientation:

• cellular_data_dialog.xml (CheckBox)
• faq_list_fragment.xml (NestedScrollView)
• profile_picture_edit_dialog.xml (2 TextViews)
• topic_activity.xml (FrameLayout)

(I only scanned layout/ and none of the variants). I know these aren't related to ConstraintLayout or FrameLayout (minus one case), but it's preferable just to get these all cleaned up while here. In general, only Guideline, RecyclerView, and LinearLayout should have orientation defined. Can you please:

1. Fix the above occurrences + their layout-land, layout-sw600dp, layout-sw600dp-port, and layout-sw600dp-land variants
2. Double check all layouts that orientation is only defined in the expected places (noting that I only personally checked layout/ in my findings above)

Thanks for double checking. I've tried to find all of these instances and clean them up as well.

[BenHenning]

Thanks @fsharpasharp! This is a nice clean-up.