Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #2003: Replacing all dimensions except space_0dp #2160

Merged
merged 17 commits into from
Nov 23, 2020
Merged

Fix part of #2003: Replacing all dimensions except space_0dp #2160

merged 17 commits into from
Nov 23, 2020

Conversation

Arjupta
Copy link
Contributor

@Arjupta Arjupta commented Nov 23, 2020 •
edited
Loading

Explanation

Fixes part of #2003 This PRreplaces all the dimensions with the one having contextful names.
(except space_0dp)

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Arjupta and others added 16 commits November 17, 2020 01:57
@Arjupta
Fix part of oppia#2003: Replacing space_32dp
fce4b83 
Fixes part of oppia#2003
This PR replaces the use of space_32dp with the dimensions having
contextful names.
@Arjupta
Resolving conflicts
6ea9288
@Arjupta
Resloving conflicts
17ade99
@Arjupta
Overiding dimensions
670fe25
@Arjupta
Overiding dimension and resolving conflicts
e0984c7
@Arjupta
Resolving conflicts with space_128dp
5e2d6bd
@Arjupta
Fixes part of oppia#2003: Replacing space_24dp
0f28eaa 
Fixes part of oppia#2003
This PR replaces the use of space_24dp with the dimensions having
contextful names.
@Arjupta
Merge branch 'develop' into replacing-space-24dp
b1214d8
@Arjupta
Resolving conflicts
3dafe0c
@Arjupta
Failing tests
e4bbf3b
@Arjupta
Fix part of oppia#2003: Replacing space_16dp,space_12dp
4b742fe 
Fixes part of oppia#2003:
This PR replaces the use of space_16dp and space_12dp with the
dimensions having contextful names.
@Arjupta
Resolving conflicts
c8a2bd4
@Arjupta
Failing Tests
4ff70f6
@Arjupta
Commiting for updating the replacing-space-16dp-12dp branch
202169d
@Arjupta
Fix part of oppia#2003: Replacing all dimensions except space_0dp
929dc60 
Fixes part of # 2003:
This PR replaces all the dimensions with the one having contextful names
(except space_0dp)
@Arjupta
updating with develop
f6d9328
@Arjupta
Copy link
Contributor Author

Arjupta commented Nov 23, 2020

@rt4914 there was no usage of space_0dp in the width or elevation property of any view. Also, I think it is better to have space_0dp as the dimension as it explains the developer that there will be no space present at the places where space_0dp is used and the dimensions elsewhere will provide the information that there will be an extra space (not caring for its value) WDYT?

@rt4914
Copy link
Contributor

rt4914 commented Nov 23, 2020

@rt4914 there was no usage of space_0dp in the width or elevation property of any view. Also, I think it is better to have space_0dp as the dimension as it explains the developer that there will be no space present at the places where space_0dp is used and the dimensions elsewhere will provide the information that there will be an extra space (not caring for its value) WDYT?

Lets keep it like this only for now. We will not close the main issue but we can assign you 150 points.

@rt4914
Copy link
Contributor

rt4914 commented Nov 23, 2020

Also your PR description points to incorrect issue number.

@Arjupta
Copy link
Contributor Author

Arjupta commented Nov 23, 2020

Is it okay know

@Arjupta Arjupta requested a review from rt4914 November 23, 2020 18:47
rt4914
rt4914 approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great work. Thanks.

@rt4914 rt4914 merged commit ac29306 into oppia:develop Nov 23, 2020
@rt4914
Copy link
Contributor

rt4914 commented Nov 23, 2020

give @Arjupta 150 points

@Arjupta Arjupta deleted the replacing-all-dimensions branch December 10, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arjupta @rt4914