Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #2003: Replacing space_72dp #2113

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

Arjupta
Copy link
Contributor

@Arjupta Arjupta commented Nov 14, 2020

Explanation

Fixes part of #2003
This PR replaces the use of space_72dp with dimensions having contextful names

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Fixes part of oppia#2003
This PR replaces the use of space_72dp with dimensions having contextful names
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @Arjupta

@rt4914 rt4914 assigned Arjupta and unassigned rt4914 Nov 15, 2020
@Arjupta Arjupta requested a review from rt4914 November 15, 2020 18:54
@rt4914 rt4914 merged commit 66f8ea0 into oppia:develop Nov 16, 2020
@Arjupta Arjupta deleted the replacing-space-72dp branch December 10, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants