Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2040: Reformating files under TextInput Package #2070

Merged
merged 7 commits into from
Nov 10, 2020
Merged

Fix #2040: Reformating files under TextInput Package #2070

merged 7 commits into from
Nov 10, 2020

Conversation

Arjupta
Copy link
Contributor

@Arjupta Arjupta commented Nov 1, 2020

Explanation

Fixes #2040 : Reformated fies under TextInput Package according to this file

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001
Copy link
Contributor

@Arjupta
Follow the below points before review:

  1. The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  2. Branch naming - https://github.com/oppia/oppia-android/wiki#instructions-for-making-a-code-change

@Arjupta Arjupta changed the title Fixes #2040: Reformating files under TextInput Package Fix #2040: Reformating files under TextInput Package Nov 2, 2020
@Arjupta
Copy link
Contributor Author

Arjupta commented Nov 2, 2020 •
edited
Loading

@Arjupta
Follow the below points before review:

  1. The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  2. Branch naming - https://github.com/oppia/oppia-android/wiki#instructions-for-making-a-code-change

Pardon me, I will use descriptive branch names for further PRs. @anandwana001 PTAL

anandwana001
anandwana001 suggested changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arjupta Left few comments.
Also, put a screenshot in the PR description showing all the test cases are passing.

...oppia/android/domain/classify/rules/textinput/TextInputContainsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
...ia/android/domain/classify/rules/textinput/TextInputFuzzyEqualsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
@anandwana001 anandwana001 assigned Arjupta and unassigned anandwana001 Nov 2, 2020
@Arjupta
Copy link
Contributor Author

Arjupta commented Nov 2, 2020 •
edited
Loading

Thanks @Arjupta Left few comments.
Also, put a screenshot in the PR description showing all the test cases are passing.

@anandwana001 Can you direct me on how to run the test of another module?

@anandwana001
Copy link
Contributor

Thanks @Arjupta Left few comments.
Also, put a screenshot in the PR description showing all the test cases are passing.

@anandwana001 Can you direct me on how to run the test of another module?

Head over to our wiki page for testing - https://github.com/oppia/oppia-android/wiki/Oppia-Android-Testing

@Arjupta
Copy link
Contributor Author

Arjupta commented Nov 3, 2020 •
edited
Loading

Thanks @Arjupta Left few comments.
Also, put a screenshot in the PR description showing all the test cases are passing.

@anandwana001 Can you direct me on how to run the test of another module?

Head over to our wiki page for testing - https://github.com/oppia/oppia-android/wiki/Oppia-Android-Testing

@anandwana001 Adding the screensnips for individual tests

Screenshot 2020-11-03 112816

Screenshot 2020-11-03 112643

Screenshot 2020-11-03 112458

Screenshot 2020-11-03 111551

Screenshot 2020-11-03 112128

rt4914
rt4914 approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

anandwana001
anandwana001 suggested changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arjupta left a comment

...oppia/android/domain/classify/rules/textinput/TextInputContainsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
@anandwana001 anandwana001 removed their assignment Nov 4, 2020
anandwana001
anandwana001 suggested changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit changes. Else good to go.

...oppia/android/domain/classify/rules/textinput/TextInputContainsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
...oppia/android/domain/classify/rules/textinput/TextInputContainsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
...oppia/android/domain/classify/rules/textinput/TextInputContainsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
...oppia/android/domain/classify/rules/textinput/TextInputContainsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
...oppia/android/domain/classify/rules/textinput/TextInputContainsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
...ia/android/domain/classify/rules/textinput/TextInputFuzzyEqualsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
...ia/android/domain/classify/rules/textinput/TextInputFuzzyEqualsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
...ia/android/domain/classify/rules/textinput/TextInputFuzzyEqualsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
...ia/android/domain/classify/rules/textinput/TextInputFuzzyEqualsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
...id/domain/classify/rules/textinput/TextInputCaseSensitiveEqualsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
@anandwana001 anandwana001 removed their assignment Nov 5, 2020
@anandwana001
Copy link
Contributor

@Arjupta please comment on comments above for further review.

anandwana001
anandwana001 suggested changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit change. @Arjupta

...pia/android/domain/classify/rules/textinput/TextInputStartsWithRuleClassifierProviderTest.kt Show resolved Hide resolved
@anandwana001 anandwana001 removed their assignment Nov 6, 2020
anandwana001
anandwana001 approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @Arjupta

Just for the future reference, please move the screenshot in the PR description, it should not be in the comment.

@anandwana001 anandwana001 removed their assignment Nov 9, 2020
@Arjupta
Copy link
Contributor Author

Arjupta commented Nov 9, 2020

LGTM, Thanks @Arjupta

Just for the future reference, please move the screenshot in the PR description, it should not be in the comment.

Okay 👍

@anandwana001
Copy link
Contributor

@rt4914 deferring to you for further merge.

@rt4914 rt4914 merged commit 40568f0 into oppia:develop Nov 10, 2020
@rt4914
Copy link
Contributor

rt4914 commented Nov 10, 2020

@aggarwalpulkit596 Please add points.

@Arjupta Arjupta deleted the reformating branch November 13, 2020 10:34
@aggarwalpulkit596
Copy link
Contributor

give @Arjupta 5 points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

Assignees

@rt4914 rt4914

@Arjupta Arjupta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix file formatting under textinput package
4 participants
@Arjupta @anandwana001 @rt4914 @aggarwalpulkit596