Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #138: Topic train fragment Low-fi UI (Part 2) #202

Merged
merged 7 commits into from
Oct 4, 2019
Merged

Fix part of #138: Topic train fragment Low-fi UI (Part 2) #202

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8cdfb33
All xml files for topic-train except layout folder
Oct 3, 2019
afd8196
Skill item related files
Oct 3, 2019
398b1e3
Nit change to Javadoc
Oct 3, 2019
0f5b521
Added TODO #172
Oct 3, 2019
7c5d662
Nit changes
Oct 3, 2019
c6c1146
Merge remote-tracking branch 'upstream/develop' into topic-train-low-…
Oct 4, 2019
2764e3b
Nit changes
Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Nit changes
  • Loading branch information
Rajat Talesra committed Oct 4, 2019
commit 2764e3bae4c348a702219994e8562c1b4ed02bb1
8 changes: 4 additions & 4 deletions app/src/main/java/org/oppia/app/topic/train/SkillSelectionAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import org.oppia.app.databinding.TopicTrainSkillViewBinding
/** Adapter to bind skills to [RecyclerView] inside [TopicTrainFragment]. */
class SkillSelectionAdapter(
private val skillList: List<String>,
private val skillInterface: SkillInterface
private val skillSelector: SkillSelector
) : RecyclerView.Adapter<RecyclerView.ViewHolder>() {

override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): RecyclerView.ViewHolder {
Expand All @@ -24,7 +24,7 @@ class SkillSelectionAdapter(
inflater,
R.layout.topic_train_skill_view,
parent,
false
/* attachToParent= */false
)
return SkillViewHolder(binding)
}
Expand All @@ -43,9 +43,9 @@ class SkillSelectionAdapter(
binding.root.skill_check_box.setOnCheckedChangeListener { buttonView, isChecked ->
val skill = skillList[position]
if (isChecked) {
skillInterface.skillSelected(skill)
skillSelector.skillSelected(skill)
} else {
skillInterface.skillUnselected(skill)
skillSelector.skillUnselected(skill)
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...g/oppia/app/topic/train/SkillInterface.kt → ...rg/oppia/app/topic/train/SkillSelector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package org.oppia.app.topic.train

/** Interface to update the selectedSkillList in [TopicTrainFragmentPresenter]. */
interface SkillInterface {
interface SkillSelector {
/** This skill will get added to selectedSkillList in [TopicTrainFragmentPresenter]. */
fun skillSelected(skill: String)
/** This skill will get removed from selectedSkillList in [TopicTrainFragmentPresenter]. */
Expand Down