Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #210 : Add Tests for NumericInputIsLessThanRuleClassifierProvider #1774

Merged
merged 22 commits into from
Sep 4, 2020
Merged

Fix part of #210 : Add Tests for NumericInputIsLessThanRuleClassifierProvider #1774

merged 22 commits into from
Sep 4, 2020

Conversation

prayutsu
Copy link
Contributor

@prayutsu prayutsu commented Sep 2, 2020

Explanation

Fixes part of #210
Added tests for NumericInputIsLessThanRuleClassifierProvider.kt

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

prayutsu and others added 21 commits August 21, 2020 22:09
@prayutsu
Merge pull request #2 from oppia/develop
b0eb1da 
update fork approved
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
038bd14 
update local copy
@prayutsu
Merge pull request #3 from oppia/develop
620c534 
update fork approved
@prayutsu
Merge pull request #6 from oppia/develop
4195b6a 
update develop
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
92bc7ab 
update develop
@prayutsu
Merge branch 'develop' of https://github.com/prayutsu/oppia-android i…
81f13e9 
…nto develop

update
@prayutsu
Merge pull request #13 from oppia/develop
f06d1be 
update my develop
@prayutsu
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
4ab3ef4 
… develop

update fork
@prayutsu
Merge remote-tracking branch 'origin/develop' into develop
0b02af9
@prayutsu
Merge pull request #14 from oppia/develop
1affc4e 
update fork
@prayutsu
check fork
da6256c
@prayutsu
Merge remote-tracking branch 'origin/develop' into develop
93f9a17
@prayutsu
local develop branch synced with remote branch
398b582
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
ae9014b
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
c08e66c
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
d347418
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
ef916a2
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
da7d6e8
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
a41b210
@prayutsu
Merge remote-tracking branch 'upstream/develop' into develop
f793875
@prayutsu
Added tests for NumericInputIsLessThanRuleClassifierProvider
1825807
@prayutsu prayutsu requested a review from rt4914 September 2, 2020 18:56
@prayutsu
Copy link
Contributor Author

prayutsu commented Sep 2, 2020

@rt4914 PTAL

@rt4914
Copy link
Contributor

rt4914 commented Sep 3, 2020

Adding @anandwana001 and @aggarwalpulkit596 as I won't be able to review this today.

@prayutsu
Copy link
Contributor Author

prayutsu commented Sep 3, 2020

@aggarwalpulkit596 PTAL

anandwana001
anandwana001 approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @prayutsu

@anandwana001 anandwana001 removed their assignment Sep 3, 2020
@rt4914
Copy link
Contributor

rt4914 commented Sep 3, 2020

@aggarwalpulkit596 merge this once your comments are resolved. Thanks.

@rt4914 rt4914 removed their assignment Sep 3, 2020
@aggarwalpulkit596 aggarwalpulkit596 merged commit bf753d1 into oppia:develop Sep 4, 2020
@aggarwalpulkit596 aggarwalpulkit596 removed their assignment Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 anandwana001 approved these changes

@aggarwalpulkit596 aggarwalpulkit596 aggarwalpulkit596 approved these changes

@rt4914 rt4914 Awaiting requested review from rt4914

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prayutsu @rt4914 @anandwana001 @aggarwalpulkit596