-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1678: Optimize Bazel protobuf rules install [BLOCKED: #1634] #1679
Conversation
… stage1_bazel_utility
…-android into stage1_bazel_testing
…-android into introduce-bazel-roboelectric-testing
…-android into introduce-bazel-roboelectric-testing
….com/oppia/oppia-android into introduce-domain-bazel-build
…ia/oppia-android into traslate-binding-adapters-to-java
…ia/oppia-android into traslate-binding-adapters-to-java
This reverts commit 84037cb.
This reverts commit ce92d0a.
This reverts commit 88c9492.
This reverts commit d66af07.
…ppia/oppia-android into optimize-protos-install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following back up. Fantastic build time improvement! I still want to better understand whether this is the correct approach & why, and ensure that's documented before we go ahead with the solution.
… build-app-library-binary-bazel
…ppia/oppia-android into introduce-robolctric-app-tests
Co-authored-by: Ben Henning <[email protected]>
…pia-android into optimize-protos-install
Co-authored-by: Ben Henning <[email protected]>
…ppia/oppia-android into introduce-robolctric-app-tests
…ppia/oppia-android into optimize-protos-install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @miaboloix!
… optimize-protos-install
Explanation
Fixes #1678: Optimize Bazel protobuf rules install.
Currently,
http_rules
in WORKSPACE are used to importrules_java
andrules_proto
, the external dependencies needed to run proto rules likeproto_library
andjava_lite_proto_library
in Bazel.However, these
http_archive
rules bring in more than what is needed to useproto_library
andjava_lite_proto_library
and some of these unused artifacts come with lengthly and expensive download times.Thanks to @anandwana001, the following solution was found: https://github.com/google/startup-os/blob/master/WORKSPACE#L173. By replacing the
http_archive
rules with these bindings and removing the now unnecessaryload()
statements frommodel/BUILD
, we are able to import only what is necessary.Building app library from clean...
Checklist