Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #1159: Topic-lessons - Tablet (Landscape) (Highfi) #1473

Merged
merged 5 commits into from
Jul 15, 2020

Conversation

MohamedMedhat1998
Copy link
Contributor

Explanation

Screenshots

MDPI Emulator (1024x768)

screenshot-2020-07-15_10 12 13 164

screenshot-2020-07-15_10 12 30 211

XHDPI Emulator (2560x1800)

screenshot-2020-07-15_10 15 50 229

screenshot-2020-07-15_10 16 10 852

Notes

  • The TabLayout will be updated in another PR
  • I used a fixed width for the items of the recycler view based on the discussion with Chantel
  • I have wrapped each item of the recycler view with a FrameLayout to center them. I could have changed the width of the recycler view itself but that will make it scrollable only from the center, which I think is a bad behavior

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 assigned MohamedMedhat1998 and unassigned rt4914 Jul 15, 2020
@MohamedMedhat1998 MohamedMedhat1998 merged commit 6dcbbc5 into develop Jul 15, 2020
@MohamedMedhat1998 MohamedMedhat1998 deleted the t-lessons-tablet-land-highfi branch July 15, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants